Re: [RFA 4/4] Return unique_xmalloc_ptr from gdbscm_scm_to_string

[Pedro Alves <palves@redhat.com>]

On 05/27/2018 04:20 PM, Tom Tromey wrote:

> diff --git a/gdb/guile/guile-internal.h b/gdb/guile/guile-internal.h
> index 2bf0cf72b2..7289d25cf1 100644
> --- a/gdb/guile/guile-internal.h
> +++ b/gdb/guile/guile-internal.h
> @@ -526,14 +526,14 @@ extern SCM gdbscm_scm_from_c_string (const char *string);
>  extern SCM gdbscm_scm_from_printf (const char *format, ...)
>      ATTRIBUTE_PRINTF (1, 2);
>  
> -extern char *gdbscm_scm_to_string (SCM string, size_t *lenp,
> -				   const char *charset,
> -				   int strict, SCM *except_scmp);
> +extern gdb::unique_xmalloc_ptr<char> gdbscm_scm_to_string
> +    (SCM string, size_t *lenp, const char *charset, int strict, SCM *except_scmp);

Two spaces.

>  
>  extern SCM gdbscm_scm_from_string (const char *string, size_t len,
>  				   const char *charset, int strict);
>  
> -extern char *gdbscm_scm_to_host_string (SCM string, size_t *lenp, SCM *except);
> +extern gdb::unique_xmalloc_ptr<char> gdbscm_scm_to_host_string
> +    (SCM string, size_t *lenp, SCM *except);

Ditto.

Otherwise OK.

Thanks,
Pedro Alves