From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 2/4] Change gdbscm_exception_message_to_string to return a unique_xmalloc_ptr
Date: Tue, 17 Jul 2018 13:08:00 -0000 [thread overview]
Message-ID: <4f3db9e6-4c5a-c29c-46ab-8ce6e1032b3a@redhat.com> (raw)
In-Reply-To: <20180527152009.4228-3-tom@tromey.com>
On 05/27/2018 04:20 PM, Tom Tromey wrote:
> ChangeLog
> 2018-05-26 Tom Tromey <tom@tromey.com>
>
> * guile/scm-param.c (pascm_signal_setshow_error): Update.
> * guile/guile-internal.h (gdbscm_exception_message_to_string):
> Update.
> * guile/scm-cmd.c (cmdscm_function): Update.
> * guile/scm-pretty-print.c
> (ppscm_print_exception_unless_memory_error): Update.
> * guile/scm-exception.c (gdbscm_exception_message_to_string):
> Return unique_xmalloc_ptr.
OK.
> @@ -601,9 +598,9 @@ gdbscm_exception_message_to_string (SCM exception)
> }
>
> gdbscm_print_exception_message (port, SCM_BOOL_F, key, args);
> - result = gdbscm_scm_to_c_string (scm_get_output_string (port));
> + gdb::unique_xmalloc_ptr<char> result
> + (gdbscm_scm_to_c_string (scm_get_output_string (port)));
> scm_close_port (port);
> -
> return result;
> }
Did you try making gdbscm_scm_to_c_string return a unique_ptr too?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-07-17 13:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-27 15:20 [RFA 0/4] some simple cleanup removal in guile Tom Tromey
2018-05-27 15:20 ` [RFA 3/4] Return unique_xmalloc_ptr from gdbscm_safe_eval_string Tom Tromey
2018-07-17 13:08 ` Pedro Alves
2018-05-27 15:20 ` [RFA 1/4] Use std::string in ppscm_make_pp_type_error_exception Tom Tromey
2018-07-17 13:08 ` Pedro Alves
2018-05-27 15:40 ` [RFA 2/4] Change gdbscm_exception_message_to_string to return a unique_xmalloc_ptr Tom Tromey
2018-07-17 13:08 ` Pedro Alves [this message]
2018-07-17 19:11 ` Tom Tromey
2018-07-18 13:29 ` [RFC] gdbscm_wrap, eliminate GDBSCM_HANDLE_GDB_EXCEPTION_WITH_CLEANUPS (Re: [RFA 2/4] Change gdbscm_exception_message_to_string to return a unique_xmalloc_ptr) Pedro Alves
2018-07-18 19:34 ` Tom Tromey
2018-07-18 22:31 ` Pedro Alves
2018-05-27 15:54 ` [RFA 4/4] Return unique_xmalloc_ptr from gdbscm_scm_to_string Tom Tromey
2018-07-17 13:09 ` Pedro Alves
2018-06-18 14:37 ` [RFA 0/4] some simple cleanup removal in guile Tom Tromey
2018-07-16 16:35 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f3db9e6-4c5a-c29c-46ab-8ce6e1032b3a@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox