From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28668 invoked by alias); 17 Jul 2018 13:08:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28602 invoked by uid 89); 17 Jul 2018 13:08:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jul 2018 13:08:37 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E3504814F0B7; Tue, 17 Jul 2018 13:08:35 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 62DA1FF5B; Tue, 17 Jul 2018 13:08:35 +0000 (UTC) Subject: Re: [RFA 2/4] Change gdbscm_exception_message_to_string to return a unique_xmalloc_ptr To: Tom Tromey , gdb-patches@sourceware.org References: <20180527152009.4228-1-tom@tromey.com> <20180527152009.4228-3-tom@tromey.com> From: Pedro Alves Message-ID: <4f3db9e6-4c5a-c29c-46ab-8ce6e1032b3a@redhat.com> Date: Tue, 17 Jul 2018 13:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180527152009.4228-3-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00509.txt.bz2 On 05/27/2018 04:20 PM, Tom Tromey wrote: > ChangeLog > 2018-05-26 Tom Tromey > > * guile/scm-param.c (pascm_signal_setshow_error): Update. > * guile/guile-internal.h (gdbscm_exception_message_to_string): > Update. > * guile/scm-cmd.c (cmdscm_function): Update. > * guile/scm-pretty-print.c > (ppscm_print_exception_unless_memory_error): Update. > * guile/scm-exception.c (gdbscm_exception_message_to_string): > Return unique_xmalloc_ptr. OK. > @@ -601,9 +598,9 @@ gdbscm_exception_message_to_string (SCM exception) > } > > gdbscm_print_exception_message (port, SCM_BOOL_F, key, args); > - result = gdbscm_scm_to_c_string (scm_get_output_string (port)); > + gdb::unique_xmalloc_ptr result > + (gdbscm_scm_to_c_string (scm_get_output_string (port))); > scm_close_port (port); > - > return result; > } Did you try making gdbscm_scm_to_c_string return a unique_ptr too? Thanks, Pedro Alves