From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30014 invoked by alias); 17 Jul 2018 13:09:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29934 invoked by uid 89); 17 Jul 2018 13:09:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jul 2018 13:08:59 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 92E985BCBE; Tue, 17 Jul 2018 13:08:57 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1894F2156893; Tue, 17 Jul 2018 13:08:56 +0000 (UTC) Subject: Re: [RFA 4/4] Return unique_xmalloc_ptr from gdbscm_scm_to_string To: Tom Tromey , gdb-patches@sourceware.org References: <20180527152009.4228-1-tom@tromey.com> <20180527152009.4228-5-tom@tromey.com> From: Pedro Alves Message-ID: <00b8ba2a-fb5a-b497-81b7-8cf77e87000d@redhat.com> Date: Tue, 17 Jul 2018 13:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180527152009.4228-5-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00511.txt.bz2 On 05/27/2018 04:20 PM, Tom Tromey wrote: > diff --git a/gdb/guile/guile-internal.h b/gdb/guile/guile-internal.h > index 2bf0cf72b2..7289d25cf1 100644 > --- a/gdb/guile/guile-internal.h > +++ b/gdb/guile/guile-internal.h > @@ -526,14 +526,14 @@ extern SCM gdbscm_scm_from_c_string (const char *string); > extern SCM gdbscm_scm_from_printf (const char *format, ...) > ATTRIBUTE_PRINTF (1, 2); > > -extern char *gdbscm_scm_to_string (SCM string, size_t *lenp, > - const char *charset, > - int strict, SCM *except_scmp); > +extern gdb::unique_xmalloc_ptr gdbscm_scm_to_string > + (SCM string, size_t *lenp, const char *charset, int strict, SCM *except_scmp); Two spaces. > > extern SCM gdbscm_scm_from_string (const char *string, size_t len, > const char *charset, int strict); > > -extern char *gdbscm_scm_to_host_string (SCM string, size_t *lenp, SCM *except); > +extern gdb::unique_xmalloc_ptr gdbscm_scm_to_host_string > + (SCM string, size_t *lenp, SCM *except); Ditto. Otherwise OK. Thanks, Pedro Alves