From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-149130-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29622 invoked by alias); 17 Jul 2018 13:08:55 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 29505 invoked by uid 89); 17 Jul 2018 13:08:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-11.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:568
X-HELO: mx1.redhat.com
Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jul 2018 13:08:48 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 9C48D402312B;	Tue, 17 Jul 2018 13:08:46 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id B7980178BF;	Tue, 17 Jul 2018 13:08:45 +0000 (UTC)
Subject: Re: [RFA 3/4] Return unique_xmalloc_ptr from gdbscm_safe_eval_string
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20180527152009.4228-1-tom@tromey.com> <20180527152009.4228-4-tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <a7dd9081-cd57-42db-50db-600fecfcdd2f@redhat.com>
Date: Tue, 17 Jul 2018 13:08:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180527152009.4228-4-tom@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-07/txt/msg00510.txt.bz2

On 05/27/2018 04:20 PM, Tom Tromey wrote:

> --- a/gdb/guile/guile-internal.h
> +++ b/gdb/guile/guile-internal.h
> @@ -402,7 +402,8 @@ extern SCM gdbscm_safe_apply_1 (SCM proc, SCM arg0, SCM args,
>  
>  extern SCM gdbscm_unsafe_call_1 (SCM proc, SCM arg0);
>  
> -extern char *gdbscm_safe_eval_string (const char *string, int display_result);
> +extern gdb::unique_xmalloc_ptr<char> gdbscm_safe_eval_string
> +    (const char *string, int display_result);

Two spaces.

Otherwise OK.

Thanks,
Pedro Alves