From: Simon Marchi <simark@simark.ca>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2 2/3] gdb, multi-target: pass a target argument to prune_threads
Date: Mon, 20 Apr 2026 13:02:38 -0400 [thread overview]
Message-ID: <a1ef0ed3-f657-4655-8362-a02f3f09cb2d@simark.ca> (raw)
In-Reply-To: <20260420134611.4009838-2-tankut.baris.aktemur@intel.com>
On 4/20/26 9:46 AM, Tankut Baris Aktemur wrote:
> diff --git a/gdb/thread.c b/gdb/thread.c
> index b47479b12e8..64c06dc87f6 100644
> --- a/gdb/thread.c
> +++ b/gdb/thread.c
> @@ -761,11 +761,13 @@ switch_to_thread_if_alive (thread_info *thr)
> /* See gdbthreads.h. */
>
> void
> -prune_threads (void)
> +prune_threads (process_stratum_target *target)
> {
> + gdb_assert (target != nullptr);
I think we should not be afraid to use references for things that must
not be nullptr.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2026-04-20 17:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 13:46 [PATCH v2 1/3] gdb: parameterize all_threads_safe for the target and ptid Tankut Baris Aktemur
2026-04-20 13:46 ` [PATCH v2 2/3] gdb, multi-target: pass a target argument to prune_threads Tankut Baris Aktemur
2026-04-20 17:02 ` Simon Marchi [this message]
2026-04-20 13:46 ` [PATCH v2 3/3] gdb, multi-target: pass a target argument to delete_exited_threads Tankut Baris Aktemur
2026-04-20 17:20 ` Simon Marchi
2026-04-21 7:48 ` Aktemur, Tankut Baris
2026-04-20 16:58 ` [PATCH v2 1/3] gdb: parameterize all_threads_safe for the target and ptid Simon Marchi
2026-04-20 17:21 ` Aktemur, Tankut Baris
2026-04-20 17:49 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1ef0ed3-f657-4655-8362-a02f3f09cb2d@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox