Re: [PATCH v2 3/3] gdb, multi-target: pass a target argument to delete_exited_threads

[Simon Marchi <simark@simark.ca>]

On 4/20/26 9:46 AM, Tankut Baris Aktemur wrote:
> diff --git a/gdb/inferior.c b/gdb/inferior.c
> index e050dec402e..1481f46cdd1 100644
> --- a/gdb/inferior.c
> +++ b/gdb/inferior.c
> @@ -368,7 +368,7 @@ inferior_appeared (struct inferior *inf, int pid)
>  {
>    /* If this is the first inferior with threads, reset the global
>       thread id.  */
> -  delete_exited_threads ();
> +  delete_exited_threads (nullptr);

Not related to your patch, but I'm a bit curious to know why this
delete_exited_threads is not done when we "mourn" the previous existence
of the inferior.  In the lifecycle of an inferior, there should always
be a point where an inferior stops "being", before "becoming" a new
execution.  At that point, the process target would be known and we
could pass it to delete_exited_threads.

> @@ -2112,7 +2112,7 @@ thread_select (const char *tidstr, thread_info *tp)
>  
>    /* Since the current thread may have changed, see if there is any
>       exited thread we can now delete.  */
> -  delete_exited_threads ();
> +  delete_exited_threads (nullptr);

I don't know if it's worthwhile, but we could restrict this one to the
process target of the previously selected thread.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon