RE: [PATCH v2 3/3] gdb, multi-target: pass a target argument to delete_exited_threads

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

On Monday, April 20, 2026 7:21 PM, Simon Marchi wrote:
> On 4/20/26 9:46 AM, Tankut Baris Aktemur wrote:
> > diff --git a/gdb/inferior.c b/gdb/inferior.c
> > index e050dec402e..1481f46cdd1 100644
> > --- a/gdb/inferior.c
> > +++ b/gdb/inferior.c
> > @@ -368,7 +368,7 @@ inferior_appeared (struct inferior *inf, int pid)
> >  {
> >    /* If this is the first inferior with threads, reset the global
> >       thread id.  */
> > -  delete_exited_threads ();
> > +  delete_exited_threads (nullptr);
> 
> Not related to your patch, but I'm a bit curious to know why this
> delete_exited_threads is not done when we "mourn" the previous existence
> of the inferior.  In the lifecycle of an inferior, there should always
> be a point where an inferior stops "being", before "becoming" a new
> execution.  At that point, the process target would be known and we
> could pass it to delete_exited_threads.

Hmm, was it maybe desired to keep the threads around at mourn phase even
in exited state for some user-interface related reason?  I'm not sure.

> > @@ -2112,7 +2112,7 @@ thread_select (const char *tidstr, thread_info *tp)
> >
> >    /* Since the current thread may have changed, see if there is any
> >       exited thread we can now delete.  */
> > -  delete_exited_threads ();
> > +  delete_exited_threads (nullptr);
> 
> I don't know if it's worthwhile, but we could restrict this one to the
> process target of the previously selected thread.

I'm inclined towards preserving the current behavior for this one.
The previous thread and the selected thread can both be from the
same target and both could be exited, meaning they could potentially
be deleted by the call.  If a behavior change is desired, IMHO it
deserves a separate patch -- the behavioral changes in other places
in this series were clear optimizations but the change here would be
more than that, I think.
 
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
> 
> Simon

Thank you.
-Baris

Intel Deutschland GmbH
Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928