From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 830GLEhc5mkG9iwAWB0awg (envelope-from ) for ; Mon, 20 Apr 2026 13:03:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776704584; bh=136j/wE7ccZHptNdoCp+HBcpztsvr/lzGfIRUjFBmP0=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=UnMZN56/IM2O4KTjG5bCm6xs4wW3+61I+TRN6K5cJvwuS8QgEl4yFPS2TIDFDQGQK yE9Twq1GYh3FED1GtXl0DLR652wFyxhF2BToC4HioIEGZIMh84PtO5/XPziKma1YQT y5g/RtCA6b+MB1WMcMw4lllZ2uKd5TR0AexQslQk= Received: by simark.ca (Postfix, from userid 112) id 9C7481E0C3; Mon, 20 Apr 2026 13:03:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=qUa+dLxW; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 134551E093 for ; Mon, 20 Apr 2026 13:03:04 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 98C284CCCA31 for ; Mon, 20 Apr 2026 17:03:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 98C284CCCA31 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=qUa+dLxW Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B86E84C900F4 for ; Mon, 20 Apr 2026 17:02:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B86E84C900F4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B86E84C900F4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776704560; cv=none; b=Q6CltEGR0LUOe8ZFBMOTCMylbbZYkf6dOOpWvJAfKBflUldgMsZsFoPxpQsX9wQy00pYJ6ARqvhyNp7NMkGF1im9NvIugqbR5qr5D17G59R+E4AVD1NQjKl6yb1xpBEcULsAsozmLRm2BC4lpVs9p1hHwKPVUbUxpzIx/JymPPE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776704560; c=relaxed/simple; bh=136j/wE7ccZHptNdoCp+HBcpztsvr/lzGfIRUjFBmP0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=kgV+/D7aSiBQkH/Ksv7jhFPOj4N9B237pJyJpp66GbYcBnjpr4b2HfKHTsG9bE8aZM83uAvd0XOfLqfGLngmZRTMjQ9o7MdgB2bfOCHZDXMTvDYwZlPUFM+Md2O+T3TiyIU1dxEKzw9rlyi0FU2qoDbQgbtt+BHkoHwmd7mcWNM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B86E84C900F4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776704559; bh=136j/wE7ccZHptNdoCp+HBcpztsvr/lzGfIRUjFBmP0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=qUa+dLxW+17tGSFtEWk4QRzG7OG/Rt1KCvYCqvMQ1ZyDsXzNk7zdgWPizgpiX+Jme 8SeLKf66qi3Bqxt1i2GIw1BECXBKU2OI1Byr33pMzWPwUK3ByjhaimF3R62csVBFtR Xlo54jRbQLrGo0mtTnyFzuDddtM2f9Ij7oz3hbz0= Received: by simark.ca (Postfix) id 87E421E093; Mon, 20 Apr 2026 13:02:39 -0400 (EDT) Message-ID: Date: Mon, 20 Apr 2026 13:02:38 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] gdb, multi-target: pass a target argument to prune_threads To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <20260420134611.4009838-1-tankut.baris.aktemur@intel.com> <20260420134611.4009838-2-tankut.baris.aktemur@intel.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260420134611.4009838-2-tankut.baris.aktemur@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/20/26 9:46 AM, Tankut Baris Aktemur wrote: > diff --git a/gdb/thread.c b/gdb/thread.c > index b47479b12e8..64c06dc87f6 100644 > --- a/gdb/thread.c > +++ b/gdb/thread.c > @@ -761,11 +761,13 @@ switch_to_thread_if_alive (thread_info *thr) > /* See gdbthreads.h. */ > > void > -prune_threads (void) > +prune_threads (process_stratum_target *target) > { > + gdb_assert (target != nullptr); I think we should not be afraid to use references for things that must not be nullptr. Approved-By: Simon Marchi Simon