From: Simon Marchi <simark@simark.ca>
To: Amos Bird <amosbird@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
gbenson@redhat.com, gdb-patches@sourceware.org, tom@tromey.com
Subject: Re: [PATCH] Add "thread-exited" annotation
Date: Fri, 17 May 2019 14:22:00 -0000 [thread overview]
Message-ID: <a0024e90-a593-b4f1-4588-d391620799f1@simark.ca> (raw)
In-Reply-To: <87r28xciz3.fsf@gmail.com>
On 2019-05-17 9:24 a.m., Amos Bird wrote:
>
> Hi Simon,
>
>> I don't mind if we start using MI-like syntax for annotation parameters, but it should
>> be a conscious decision to do so.
>
> To be honest I don't use the extra information at all in cgdb, only "thread-exited". So
> I'm OK to whatever format it ends up to have.
>
> Patch updated, thanks!
The test fails here, please verify that the it passes using:
gdb/ $ make check TESTS="gdb.base/annota1.exp"
You'll need at least to declare "global decimal" to be able to access the decimal variable.
When adding that, I get a FAIL that I don't get without the patch applied:
FAIL: gdb.base/annota1.exp: signal sent (timeout)
Any interesting output will end up in testsuite/gdb.log.
Simon
next prev parent reply other threads:[~2019-05-17 14:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 15:19 Amos Bird
2019-04-30 15:45 ` Tom Tromey
2019-04-30 17:09 ` Amos Bird
2019-05-16 13:14 ` Gary Benson
2019-05-16 14:10 ` Amos Bird
2019-05-16 14:35 ` Eli Zaretskii
2019-05-16 14:45 ` Amos Bird
2019-05-17 9:59 ` Gary Benson
2019-05-17 10:55 ` Amos Bird
2019-05-17 13:08 ` Simon Marchi
[not found] ` <87r28xciz3.fsf@gmail.com>
2019-05-17 14:22 ` Simon Marchi [this message]
[not found] ` <87pnohcc5t.fsf@gmail.com>
2019-05-17 16:26 ` Pedro Alves
2019-05-17 17:13 ` Amos Bird
2019-06-06 15:37 ` Amos Bird
2019-06-06 16:32 ` Pedro Alves
2019-06-06 17:11 ` Amos Bird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0024e90-a593-b4f1-4588-d391620799f1@simark.ca \
--to=simark@simark.ca \
--cc=amosbird@gmail.com \
--cc=eliz@gnu.org \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox