From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3126 invoked by alias); 17 May 2019 14:22:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3098 invoked by uid 89); 17 May 2019 14:22:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:791 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 May 2019 14:22:06 +0000 Received: from [172.16.0.120] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 561C01E636; Fri, 17 May 2019 10:22:04 -0400 (EDT) Subject: Re: [PATCH] Add "thread-exited" annotation To: Amos Bird Cc: Eli Zaretskii , gbenson@redhat.com, gdb-patches@sourceware.org, tom@tromey.com References: <87d0l8pzdz.fsf@gmail.com> <87ef5j33au.fsf@tromey.com> <87ftpzo1wa.fsf@gmail.com> <20190516131419.GA29999@blade.nx> <87ftpepk1l.fsf@gmail.com> <83d0kicvs6.fsf@gnu.org> <87ef4ypif5.fsf@gmail.com> <441e0b74-a391-2d68-e5d3-f43f1b8da188@simark.ca> <87r28xciz3.fsf@gmail.com> From: Simon Marchi Message-ID: Date: Fri, 17 May 2019 14:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87r28xciz3.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-05/txt/msg00420.txt.bz2 On 2019-05-17 9:24 a.m., Amos Bird wrote: > > Hi Simon, > >> I don't mind if we start using MI-like syntax for annotation parameters, but it should >> be a conscious decision to do so. > > To be honest I don't use the extra information at all in cgdb, only "thread-exited". So > I'm OK to whatever format it ends up to have. > > Patch updated, thanks! The test fails here, please verify that the it passes using: gdb/ $ make check TESTS="gdb.base/annota1.exp" You'll need at least to declare "global decimal" to be able to access the decimal variable. When adding that, I get a FAIL that I don't get without the patch applied: FAIL: gdb.base/annota1.exp: signal sent (timeout) Any interesting output will end up in testsuite/gdb.log. Simon