From: Tom Tromey <tom@tromey.com>
To: Amos Bird <amosbird@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add "thread-exited" annotation
Date: Tue, 30 Apr 2019 15:45:00 -0000 [thread overview]
Message-ID: <87ef5j33au.fsf@tromey.com> (raw)
In-Reply-To: <87d0l8pzdz.fsf@gmail.com> (Amos Bird's message of "Fri, 26 Apr 2019 23:19:52 +0800")
>>>>> "Amos" == Amos Bird <amosbird@gmail.com> writes:
Amos> This patch adds "thread-exited" annotation so that annotation based
Amos> clients like cgdb could currently handle thread exit.
I sort of wish that all clients would just use MI, but ...
Amos> +2019-04-26 Amos Bird <amosbird@gmail.com>
Amos> +
Amos> + * annotate.c (annotate_thread_exited): Add "thread-exited"
Amos> + annotation.
The patch itself is fine (just some nits), but a change like this
requires a documentation update (and probably NEWS as well) and a test
case.
Amos> +void
Amos> +annotate_thread_exited (struct thread_info *t, int silent)
Amos> +{
New functions should have an intro comment. Also, this function should
be "static".
Tom
next prev parent reply other threads:[~2019-04-30 15:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 15:19 Amos Bird
2019-04-30 15:45 ` Tom Tromey [this message]
2019-04-30 17:09 ` Amos Bird
2019-05-16 13:14 ` Gary Benson
2019-05-16 14:10 ` Amos Bird
2019-05-16 14:35 ` Eli Zaretskii
2019-05-16 14:45 ` Amos Bird
2019-05-17 9:59 ` Gary Benson
2019-05-17 10:55 ` Amos Bird
2019-05-17 13:08 ` Simon Marchi
[not found] ` <87r28xciz3.fsf@gmail.com>
2019-05-17 14:22 ` Simon Marchi
[not found] ` <87pnohcc5t.fsf@gmail.com>
2019-05-17 16:26 ` Pedro Alves
2019-05-17 17:13 ` Amos Bird
2019-06-06 15:37 ` Amos Bird
2019-06-06 16:32 ` Pedro Alves
2019-06-06 17:11 ` Amos Bird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef5j33au.fsf@tromey.com \
--to=tom@tromey.com \
--cc=amosbird@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox