Re: [PATCH] Add "thread-exited" annotation

[Simon Marchi <simark@simark.ca>]

Hi Amos,

Some comments related to the format of arguments passed with the annotation:

> +      printf_filtered(("\n\032\032thread-exited,"
> +                       "id=\"%d\",group-id=\"i%d\"\n"),
> +                      t->global_num, t->inf->num);

Do we use this style of MI-like record anywhere else in the annotations interface?

Other annotations that have extra info seem to just pass magic numbers after the
annotation name, such as:

    printf_filtered (("\n\032\032frame-begin %d %s\n"),
		     level, paddress (gdbarch, pc));

I don't mind if we start using MI-like syntax for annotation parameters, but it should
be a conscious decision to do so.  And if we ever add more annotations in the future, it
should follow the same pattern.

> diff --git a/gdb/doc/annotate.texinfo b/gdb/doc/annotate.texinfo
> index b85b759f9a..fb7cbf7b77 100644
> --- a/gdb/doc/annotate.texinfo
> +++ b/gdb/doc/annotate.texinfo
> @@ -836,6 +836,11 @@ The selected thread has changed.  This may occur at the request of the
>  user with the @code{thread} command, or as a result of execution,
>  e.g., another thread hits a breakpoint.
>
> +@findex thread-exited@r{, annotation}
> +@item ^Z^Zthread-exited
> +
> +This annotation is issued once for each thread that exits.
> +
>  @end table

In any case, the documentation should describe the format and meaning of
information passed with the annotation.

> +proc thread_exit {} {
> +    gdb_test_multiple "call (void)pthread_exit()" "thread exit" {
> +	-re ".*\032\032thread-exited.*" {
> +	    pass "thread exit"
> +	}
> +    }
> +}

Please enhance the regex to include the extra information, like (untested):

  -re ".*\032\032thread-exited,id=\"${decimal}\",group-id=\"i${decimal}\""

Simon