From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Add missing stdlib.h includes to sim
Date: Tue, 4 May 2021 13:44:45 -0400 [thread overview]
Message-ID: <YJGIDUuttWqaR2vv@vapier> (raw)
In-Reply-To: <20210504145818.4088770-4-tromey@adacore.com>
On 04 May 2021 08:58, Tom Tromey wrote:
> This updates the various "mloop.in" files to emit an include of
> stdlib.h, to avoid warnings about 'abort' being undeclared.
i was debating how to approach this. the mloop code that gets inserted here
is in the middle of the file, so there's a couple of funcs defined before this
include is hit. things are generally namespaced, so maybe it's not a big deal,
but still felt a bit off which is why i was sitting on it. the alternative is
to add a new callback point just for early headers and then the script would
emit stdlib.h and such then.
but maybe i'm being too ornery and your fix is fine. feel free to merge.
-mike
next prev parent reply other threads:[~2021-05-04 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 14:58 [PATCH 0/3] Some minor sim fixes Tom Tromey
2021-05-04 14:58 ` [PATCH 1/3] Add config.h to generated_files for sim Tom Tromey
2021-05-04 17:38 ` Mike Frysinger via Gdb-patches
2021-05-04 14:58 ` [PATCH 2/3] Fix igen build Tom Tromey
2021-05-04 17:38 ` Mike Frysinger via Gdb-patches
2021-05-04 14:58 ` [PATCH 3/3] Add missing stdlib.h includes to sim Tom Tromey
2021-05-04 17:44 ` Mike Frysinger via Gdb-patches [this message]
2021-05-04 19:17 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJGIDUuttWqaR2vv@vapier \
--to=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox