From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id R2h0HxCIkWBeaAAAWB0awg (envelope-from ) for ; Tue, 04 May 2021 13:44:48 -0400 Received: by simark.ca (Postfix, from userid 112) id 7317C1F11C; Tue, 4 May 2021 13:44:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E4B4B1E01F for ; Tue, 4 May 2021 13:44:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 953003955401; Tue, 4 May 2021 17:44:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 953003955401 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620150287; bh=k/Dl9NFVQbEKCjnfUc2P6ZBHRhJbwqP8imcTj7ogSnI=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OAaPDtrydNcfE/Lz74eqkZc9ceuIabwsHLFtvCRL2rmhcSle+CHW+Ebi03IwB0Frl SqRUC7dz5DPh1sxZtZOObS4ri3HQD7HZTM/mUs+ZMDKBWt0p4iNpO6bPjhRFOfnMSO gwlOFgMQBLQOQIKr/kMoKZzM/xX82RSiA83ce2EI= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id E33F4385E00D for ; Tue, 4 May 2021 17:44:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E33F4385E00D Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 2DF58340BB4; Tue, 4 May 2021 17:44:45 +0000 (UTC) Date: Tue, 4 May 2021 13:44:45 -0400 To: Tom Tromey Subject: Re: [PATCH 3/3] Add missing stdlib.h includes to sim Message-ID: Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: <20210504145818.4088770-1-tromey@adacore.com> <20210504145818.4088770-4-tromey@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210504145818.4088770-4-tromey@adacore.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 04 May 2021 08:58, Tom Tromey wrote: > This updates the various "mloop.in" files to emit an include of > stdlib.h, to avoid warnings about 'abort' being undeclared. i was debating how to approach this. the mloop code that gets inserted here is in the middle of the file, so there's a couple of funcs defined before this include is hit. things are generally namespaced, so maybe it's not a big deal, but still felt a bit off which is why i was sitting on it. the alternative is to add a new callback point just for early headers and then the script would emit stdlib.h and such then. but maybe i'm being too ornery and your fix is fine. feel free to merge. -mike