From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Add missing stdlib.h includes to sim
Date: Tue, 04 May 2021 13:17:39 -0600 [thread overview]
Message-ID: <87mttas3zg.fsf@tromey.com> (raw)
In-Reply-To: <YJGIDUuttWqaR2vv@vapier> (Mike Frysinger's message of "Tue, 4 May 2021 13:44:45 -0400")
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> On 04 May 2021 08:58, Tom Tromey wrote:
>> This updates the various "mloop.in" files to emit an include of
>> stdlib.h, to avoid warnings about 'abort' being undeclared.
Mike> i was debating how to approach this. the mloop code that gets inserted here
Mike> is in the middle of the file, so there's a couple of funcs defined before this
Mike> include is hit. things are generally namespaced, so maybe it's not a big deal,
Mike> but still felt a bit off which is why i was sitting on it. the alternative is
Mike> to add a new callback point just for early headers and then the script would
Mike> emit stdlib.h and such then.
Or it could just unconditionally emit <stdlib.h>.
Mike> but maybe i'm being too ornery and your fix is fine. feel free to merge.
I guess I'll just do it. It can always be changed again, easy enough to
do.
Tom
prev parent reply other threads:[~2021-05-04 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 14:58 [PATCH 0/3] Some minor sim fixes Tom Tromey
2021-05-04 14:58 ` [PATCH 1/3] Add config.h to generated_files for sim Tom Tromey
2021-05-04 17:38 ` Mike Frysinger via Gdb-patches
2021-05-04 14:58 ` [PATCH 2/3] Fix igen build Tom Tromey
2021-05-04 17:38 ` Mike Frysinger via Gdb-patches
2021-05-04 14:58 ` [PATCH 3/3] Add missing stdlib.h includes to sim Tom Tromey
2021-05-04 17:44 ` Mike Frysinger via Gdb-patches
2021-05-04 19:17 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mttas3zg.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox