From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iCV1GNqdkWBsagAAWB0awg (envelope-from ) for ; Tue, 04 May 2021 15:17:46 -0400 Received: by simark.ca (Postfix, from userid 112) id 57A831F11C; Tue, 4 May 2021 15:17:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 906251E54D for ; Tue, 4 May 2021 15:17:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 039C03851C04; Tue, 4 May 2021 19:17:45 +0000 (GMT) Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id B84F23851C04 for ; Tue, 4 May 2021 19:17:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B84F23851C04 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3993911767F; Tue, 4 May 2021 15:17:40 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id bXmYBahb7msn; Tue, 4 May 2021 15:17:40 -0400 (EDT) Received: from murgatroyd (97-122-70-176.hlrn.qwest.net [97.122.70.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id DDFDB1175A6; Tue, 4 May 2021 15:17:39 -0400 (EDT) From: Tom Tromey To: Tom Tromey Subject: Re: [PATCH 3/3] Add missing stdlib.h includes to sim References: <20210504145818.4088770-1-tromey@adacore.com> <20210504145818.4088770-4-tromey@adacore.com> X-Attribution: Tom Date: Tue, 04 May 2021 13:17:39 -0600 In-Reply-To: (Mike Frysinger's message of "Tue, 4 May 2021 13:44:45 -0400") Message-ID: <87mttas3zg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Mike" == Mike Frysinger writes: Mike> On 04 May 2021 08:58, Tom Tromey wrote: >> This updates the various "mloop.in" files to emit an include of >> stdlib.h, to avoid warnings about 'abort' being undeclared. Mike> i was debating how to approach this. the mloop code that gets inserted here Mike> is in the middle of the file, so there's a couple of funcs defined before this Mike> include is hit. things are generally namespaced, so maybe it's not a big deal, Mike> but still felt a bit off which is why i was sitting on it. the alternative is Mike> to add a new callback point just for early headers and then the script would Mike> emit stdlib.h and such then. Or it could just unconditionally emit . Mike> but maybe i'm being too ornery and your fix is fine. feel free to merge. I guess I'll just do it. It can always be changed again, easy enough to do. Tom