From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Fix igen build
Date: Tue, 4 May 2021 13:38:44 -0400 [thread overview]
Message-ID: <YJGGpDUI6gmE2NB7@vapier> (raw)
In-Reply-To: <20210504145818.4088770-3-tromey@adacore.com>
On 04 May 2021 08:58, Tom Tromey wrote:
> The igen build fails for me like:
>
> gcc -g -O2 -c ../../binutils-gdb/sim/igen/igen.c -o igen/igen.o
> In file included from ../../binutils-gdb/sim/igen/igen.c:26:
> ../../binutils-gdb/sim/igen/lf.h:22:10: fatal error: ansidecl.h: No such file or directory
>
> This patch fixes the problem by arranging for igen to find the
> libiberty includes.
>
> This seems slightly hacky to me, because libiberty is not a "build"
> library, so it can't be linked against. However, since igen currently
> only includes the header, it seems relatively safe.
since it's only hitting srcroot i think it's OK. if it was hitting the
build paths, then we'd be in trouble.
-mike
next prev parent reply other threads:[~2021-05-04 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 14:58 [PATCH 0/3] Some minor sim fixes Tom Tromey
2021-05-04 14:58 ` [PATCH 1/3] Add config.h to generated_files for sim Tom Tromey
2021-05-04 17:38 ` Mike Frysinger via Gdb-patches
2021-05-04 14:58 ` [PATCH 2/3] Fix igen build Tom Tromey
2021-05-04 17:38 ` Mike Frysinger via Gdb-patches [this message]
2021-05-04 14:58 ` [PATCH 3/3] Add missing stdlib.h includes to sim Tom Tromey
2021-05-04 17:44 ` Mike Frysinger via Gdb-patches
2021-05-04 19:17 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJGGpDUI6gmE2NB7@vapier \
--to=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox