From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +H1NHqmGkWDlZwAAWB0awg (envelope-from ) for ; Tue, 04 May 2021 13:38:49 -0400 Received: by simark.ca (Postfix, from userid 112) id 7A36F1F11C; Tue, 4 May 2021 13:38:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 946991E01F for ; Tue, 4 May 2021 13:38:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 505D2398B40B; Tue, 4 May 2021 17:38:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 505D2398B40B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620149928; bh=F3Hf4awMOkthUyv9rH8tyxxEgqjN9IUhFlFiETpvf6I=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DxHsTjTZ9obAaHO4/u49KZCqL4+xPFmUIxtEohdcdWkDfTFfy4pNmAhYd4PzJwrTF XkMZMm018zk4NwBdoIxTbv2u0hSWN1MQwUZe0sZw6/Fkubc3DCTYTlp/R4XQ9OJ4D5 SytfE+zO6GC39ksUtJ84GXSiqwRevgUQcnf7d+mc= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 0D0B0398B40B for ; Tue, 4 May 2021 17:38:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0D0B0398B40B Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 2C704340BB4; Tue, 4 May 2021 17:38:45 +0000 (UTC) Date: Tue, 4 May 2021 13:38:44 -0400 To: Tom Tromey Subject: Re: [PATCH 2/3] Fix igen build Message-ID: Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: <20210504145818.4088770-1-tromey@adacore.com> <20210504145818.4088770-3-tromey@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210504145818.4088770-3-tromey@adacore.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 04 May 2021 08:58, Tom Tromey wrote: > The igen build fails for me like: > > gcc -g -O2 -c ../../binutils-gdb/sim/igen/igen.c -o igen/igen.o > In file included from ../../binutils-gdb/sim/igen/igen.c:26: > ../../binutils-gdb/sim/igen/lf.h:22:10: fatal error: ansidecl.h: No such file or directory > > This patch fixes the problem by arranging for igen to find the > libiberty includes. > > This seems slightly hacky to me, because libiberty is not a "build" > library, so it can't be linked against. However, since igen currently > only includes the header, it seems relatively safe. since it's only hitting srcroot i think it's OK. if it was hitting the build paths, then we'd be in trouble. -mike