RE: [PATCH 6/9] gdb: Implement 'bt shadow' to print the shadow stack backtrace.

["Schimpe, Christina" <christina.schimpe@intel.com>]

> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Donnerstag, 19. Februar 2026 18:24
> To: Schimpe, Christina <christina.schimpe@intel.com>
> Cc: Tom Tromey <tom@tromey.com>; gdb-patches@sourceware.org
> Subject: Re: [PATCH 6/9] gdb: Implement 'bt shadow' to print the shadow
> stack backtrace.
> 
> >>>>> Schimpe, Christina <christina.schimpe@intel.com> writes:
> 
> > Hi Tom,
> > Thank you for the feedback.
> > Please see my comment for annotations below.
> 
> Sorry about the delay in my response here.
> 
> > Alternatively, I see 2 options:
> > -  I could add a check and in case of bt shadow not print annotations
> > at all
> > -  Remove annotations for the bt command completely
> 
> > I only found this comment in the docs:
> > "The annotation mechanism has largely been superseded by GDB/MI (see
> GDB/MI)."
> > https://sourceware.org/gdb/current/onlinedocs/gdb.html/Annotations.htm
> > l#Annotations I am not sure if that means that they are deprecated or
> > just rarely used. But maybe I am missing something.
> 
> > What do you think?
> 
> I didn't re-read the patch but essentially I would not bother adding
> annotations to any new code.

If I'll remove them and somebody would run the "bt -shadow" command,
he'd have annotations only partially as we'll miss the shadow stack specific parts,
for example, "shadow-stack-frame-begin".
And this is acceptable since we don't expect anybody to enable them. 

In that case I'll simply remove them.

Thanks,
Christina
Intel Deutschland GmbH
Registered Address: Dornacher Straße 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht München HRB 186928