Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Eli Zaretskii <eliz@gnu.org>,
	"Schimpe, Christina" <christina.schimpe@intel.com>
Cc: gdb-patches@sourceware.org, thiago.bauermann@linaro.org
Subject: Re: [PATCH 6/9] gdb: Implement 'bt shadow' to print the shadow stack backtrace.
Date: Thu, 25 Sep 2025 10:58:41 -0400	[thread overview]
Message-ID: <3b44b772-7936-4c39-b743-716f585bd334@simark.ca> (raw)
In-Reply-To: <86plbebrf1.fsf@gnu.org>

On 9/25/25 9:19 AM, Eli Zaretskii wrote:
>> From: "Schimpe, Christina" <christina.schimpe@intel.com>
>> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, "Thiago Jung
>>  Bauermann" <thiago.bauermann@linaro.org>
>> Date: Thu, 25 Sep 2025 11:06:32 +0000
>>
>>>> (gdb) help bt shadow
>>>> Print backtrace of all shadow stack frames, or innermost COUNT frames.
>>>> Usage: backtrace shadow [OPTION]... [COUNT | -COUNT]
>>>
>>> Thanks, but I wonder if this UI is the best we can come up with.
>>> The "backtrace" command doesn't currently have non-option arguments
>>> except COUNT. 
>>
>> Hm, not sure if I fully understand what you mean by non-option arguments.
>> "bt shadow" does not introduce more non-option arguments, except if you say
>> that "shadow" itself is interpreted as "non-option" argument.
> 
> That's what I'm saying, yes.
> 
>>> We have just got rid of qualifier arguments like "full"
>>> and "hide".  Instead of introducing qualifier arguments anew, why not go the
>>> way of thread-related commands and add a new command "shadow", so the
>>> user could say "shadow backtrace" and maybe in the future also other sub-
>>> commands?
>>
>> This has been discussed in a thread years ago:
>> https://sourceware.org/pipermail/gdb/2023-December/051024.html
>> The direction was to make it part of the ordinary bt command. 
> 
> OK, if that's what the others want...

My initial reaction was: why not use a "-shadow" option to the backtrace
command, instead of introducing "backtrace shadow", which is effectively
a separate command?  I then re-read the thread above, and I saw that
"-shadow" was actually part of the options considered, and even seemed
like the preferred option of many.  I didn't see "backtrace shadow"
proposed there, so I'm confused.

The thing I don't like about "backtrace shadow" is: I don't like when a
command ("backtrace") is both a prefix and a regular command.  It can
paint us in a corner at some point.  Let's say we want to introduce the
syntax:

  (gdb) backtrace SYMBOL

at some point, then the sub-command "shadow" would conflict if someone
wanted to call the command "backtrace" with the symbol "shadow".

From what I read in the thread above, the downside of the "backtrace
-shadow" option is that some other options wouldn't make sense for the
shadow backtrace.  I don't think it's a problem, those other options can
just be ignored when printing the shadow stack.

Simon

  reply	other threads:[~2025-09-25 14:59 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23 11:18 [PATCH 0/9] Add new command " Christina Schimpe
2025-09-23 11:18 ` [PATCH 1/9] gdb: Generalize handling of the shadow stack pointer Christina Schimpe
2025-10-31  1:31   ` Thiago Jung Bauermann
2025-11-17 11:18     ` Schimpe, Christina
2025-11-26  4:19       ` Thiago Jung Bauermann
2025-12-30 10:39         ` Schimpe, Christina
2025-09-23 11:18 ` [PATCH 2/9] gdb: Refactor 'stack.c:print_frame' Christina Schimpe
2025-10-03 20:05   ` Tom Tromey
2025-09-23 11:18 ` [PATCH 3/9] gdb: Introduce 'stack.c:print_pc' function without frame argument Christina Schimpe
2025-10-03 19:56   ` Tom Tromey
2025-09-23 11:18 ` [PATCH 4/9] gdb: Refactor 'find_symbol_funname' and 'info_frame_command_core' in stack.c Christina Schimpe
2025-10-03 19:55   ` Tom Tromey
2025-09-23 11:18 ` [PATCH 5/9] gdb: Refactor 'stack.c:print_frame_info' Christina Schimpe
2025-10-03 20:03   ` Tom Tromey
2025-09-23 11:18 ` [PATCH 6/9] gdb: Implement 'bt shadow' to print the shadow stack backtrace Christina Schimpe
2025-09-23 11:47   ` Eli Zaretskii
2025-09-25 11:06     ` Schimpe, Christina
2025-09-25 13:19       ` Eli Zaretskii
2025-09-25 14:58         ` Simon Marchi [this message]
2025-09-26  7:45           ` Schimpe, Christina
2025-10-29 15:05             ` Schimpe, Christina
2025-10-29 15:28               ` Guinevere Larsen
2025-11-03 19:47                 ` Schimpe, Christina
2025-11-04 11:53                   ` Guinevere Larsen
2025-11-05 16:33                     ` Schimpe, Christina
2025-10-13  1:17       ` Thiago Jung Bauermann
2025-10-13  7:19         ` Schimpe, Christina
2025-10-31  4:39           ` Thiago Jung Bauermann
2025-11-06 14:23             ` Schimpe, Christina
2025-10-03 20:15   ` Tom Tromey
2025-10-12 19:45     ` Schimpe, Christina
2026-02-19 17:24       ` Tom Tromey
2026-03-02 12:24         ` Schimpe, Christina
2025-10-31  4:02   ` Thiago Jung Bauermann
2025-11-17 20:14     ` Schimpe, Christina
2025-11-26  4:07       ` Thiago Jung Bauermann
2025-11-26 16:29         ` Thiago Jung Bauermann
2026-01-22 17:04           ` Schimpe, Christina
2026-03-06  2:35             ` Thiago Jung Bauermann
2026-01-15 14:05         ` Schimpe, Christina
2025-09-23 11:18 ` [PATCH 7/9] gdb: Provide gdbarch hook to distinguish shadow stack backtrace elements Christina Schimpe
2025-09-23 11:49   ` Eli Zaretskii
2025-09-25 11:10     ` Schimpe, Christina
2025-11-02 21:20       ` Thiago Jung Bauermann
2025-11-12 17:28         ` Schimpe, Christina
2025-11-16 18:39           ` Thiago Jung Bauermann
2025-11-17 11:51             ` Schimpe, Christina
2025-09-23 11:18 ` [PATCH 8/9] gdb: Implement the hook 'is_no_return_shadow_stack_address' for amd64 linux Christina Schimpe
2025-11-26  4:22   ` Thiago Jung Bauermann
2025-09-23 11:18 ` [PATCH 9/9] gdb, mi: Add -shadow-stack-list-frames command Christina Schimpe
2025-09-23 11:53   ` Eli Zaretskii
2025-09-25 11:32     ` Schimpe, Christina
2025-10-03 20:17   ` Tom Tromey
2025-10-12 19:54     ` Schimpe, Christina
2025-10-13  0:06       ` Thiago Jung Bauermann
2025-11-26  4:26   ` Thiago Jung Bauermann
2026-01-22 17:01     ` Schimpe, Christina
2026-03-06  2:44       ` Thiago Jung Bauermann
2025-09-25 11:46 ` [PATCH 0/9] Add new command to print the shadow stack backtrace Schimpe, Christina
2025-10-08  1:46   ` Thiago Jung Bauermann
2025-10-13  1:18     ` Thiago Jung Bauermann
2025-10-13  6:34       ` Schimpe, Christina
2025-10-29 14:52         ` Schimpe, Christina
2025-10-31  0:47           ` Thiago Jung Bauermann
2025-12-30 10:16             ` Schimpe, Christina
2026-03-06  2:30               ` Thiago Jung Bauermann
2026-03-12  9:53                 ` Schimpe, Christina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b44b772-7936-4c39-b743-716f585bd334@simark.ca \
    --to=simark@simark.ca \
    --cc=christina.schimpe@intel.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=thiago.bauermann@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox