[rfa/i386] Consolidate i386 targets

[rfa/i386] Consolidate i386 targets

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

Hello,

This patch replaces a number of explicit i386 (-aout, -coff, -elf, -pe) 
targets with a generic ``i386-*'' pattern.

It then updates the MAINTAINERS file so that only one i386 target is 
listed or building: i386-elf.  This should cut down on the number of 
targets that need building.

ok?
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1994 bytes --]

2002-08-03  Andrew Cagney  <ac131313@redhat.com>

	* configure.tgt: Replace i[3456]86-*-pe*, i[3456]86-*-aout*,
	i[3456]86-*-coff* and i[3456]86-*-elf* with catch all i[3456]86-*.
	* MAINTAINERS: Drop i386-aout and i586-pc-msdosdjgpp from target
	list.

Index: MAINTAINERS
===================================================================
RCS file: /cvs/src/src/gdb/MAINTAINERS,v
retrieving revision 1.191
diff -u -r1.191 MAINTAINERS
--- MAINTAINERS	24 Jul 2002 23:51:35 -0000	1.191
+++ MAINTAINERS	3 Aug 2002 20:30:55 -0000
@@ -80,9 +80,6 @@
 
 	d30v		(--target=d30v-elf OBSOLETE)
 
-	djgpp		--target=i586-pc-msdosdjgpp ,-Werror
-			(See native and host)
-
 	fr30		(--target=fr30-elf OBSOLETE)
 
 	h8300		--target=h8300hms -Werror
@@ -93,7 +90,7 @@
 			Maintenance only
 			Not multi-arch, work in progress
 
-	i386		--target=i386-elf,i386-aout ,-Werror
+	i386		--target=i386-elf ,-Werror
 			Mark Kettenis           kettenis@gnu.org
 
 	i960		--target=i960-coff ,-Werror
Index: configure.tgt
===================================================================
RCS file: /cvs/src/src/gdb/configure.tgt,v
retrieving revision 1.75
diff -u -r1.75 configure.tgt
--- configure.tgt	24 Jul 2002 23:51:35 -0000	1.75
+++ configure.tgt	3 Aug 2002 20:30:55 -0000
@@ -87,9 +87,6 @@
 i[3456]86-sequent-sysv4*) gdb_target=ptx4 ;;
 i[3456]86-sequent-sysv*) gdb_target=ptx ;;
 i[3456]86-ncr-*)	gdb_target=ncr3000 ;;
-i[3456]86-*-aout*)	gdb_target=embed ;;
-i[3456]86-*-coff*)	gdb_target=embed ;;
-i[3456]86-*-elf*)	gdb_target=embed ;;
 i[3456]86-*-aix*)	gdb_target=i386aix ;;
 i[3456]86-*-bsd*)	gdb_target=i386bsd ;;
 i[3456]86-*-freebsd*)	gdb_target=fbsd ;;
@@ -118,8 +115,8 @@
 		configdirs="${configdirs} nlm" ;;
 i[3456]86-*-osf1mk*)	gdb_target=i386mk ;;
 i[3456]86-*-cygwin*)	gdb_target=cygwin  ;;
-i[3456]86-*-pe*)	gdb_target=embed  ;;
 i[3456]86-*-vxworks*)	gdb_target=vxworks ;;
+i[3456]86-*)		gdb_target=embed ;;
 
 i960-*-bout*)		gdb_target=vxworks960 ;;
 i960-nindy-coff*)	gdb_target=nindy960 ;;

Re: [rfa/i386] Consolidate i386 targets

[Eli Zaretskii]

On Sat, 3 Aug 2002, Andrew Cagney wrote:

> This patch replaces a number of explicit i386 (-aout, -coff, -elf, -pe) 
> targets with a generic ``i386-*'' pattern.
> 
> It then updates the MAINTAINERS file so that only one i386 target is 
> listed or building: i386-elf.  This should cut down on the number of 
> targets that need building.

Why is this part a good idea?  DJGPP is still supported, right?

>        * MAINTAINERS: Drop i386-aout and i586-pc-msdosdjgpp from target
>        list.

Did I miss something?

Re: [rfa/i386] Consolidate i386 targets

[Andrew Cagney]

> On Sat, 3 Aug 2002, Andrew Cagney wrote:
> 
> 
>> This patch replaces a number of explicit i386 (-aout, -coff, -elf, -pe) 
>> targets with a generic ``i386-*'' pattern.
>> 
>> It then updates the MAINTAINERS file so that only one i386 target is 
>> listed or building: i386-elf.  This should cut down on the number of 
>> targets that need building.
> 
> 
> Why is this part a good idea?  DJGPP is still supported, right?

Yes, DJGPP is definitly still supported.  DJGPP is a native 
configuration though, and the above list applies to the cross debuggers.

>>        * MAINTAINERS: Drop i386-aout and i586-pc-msdosdjgpp from target
>>        list.
> 
> 
> Did I miss something?

I don't think so.  My understanding of the thread:
http://sources.redhat.com/ml/gdb-patches/2002-05/msg00774.html

> Date: Fri, 17 May 2002 13:21:46 -0400
>> From: Daniel Jacobowitz <drow@mvista.com>
> 
>> > 
>> > Sorry, I still don't understand: does this mean a remote debugger with
>> > some stub on the remote DOS/Windows machine?  Or maybe the stub (or
>> > gdbserver) running inside DOSEmu on the GNU/Linux box?
> 
>> 
>> Those are both valid.
>> 
> 
>> > My point is that DJGPP debugging is very special: there's no OS
>> > provision for system calls like ptrace etc., so the only way to debug
>> > a DJGPP inferior is to run it natively under a specially built program
>> > that is linked against the DJGPP debug support library.  I'm curious
>> > how does your cross build achieve that, since I believe neither
>> > gdbserver nor any of the remote-* modules support DJGPP as of now.
> 
>> 
>> I didn't say it would be useful.  But consult MAINTAINERS; everything
>> listed in the "Targets" section on a --target= line is currently
>> "expected" to be buildable as a cross debugger, to sanity check
>> changes.  That's all I was doing.
> 
> 
> Then I don't think you (or anyone else on this list) should be
> concerned with these problems: IMHO, a failure to build a
> dysfunctional version of GDB is not a failure at all.

is that trying to ensure that a cross DJGPP debugger always builds isn't 
useful.

enjoy,
Andrew

Re: [rfa/i386] Consolidate i386 targets

[Eli Zaretskii]

On Sun, 4 Aug 2002, Andrew Cagney wrote:

> Yes, DJGPP is definitly still supported.  DJGPP is a native 
> configuration though, and the above list applies to the cross debuggers.

I think that might confuse someone (it did confuse me): there's only one 
list of targets in MAINTAINERS, so I thought it pertains to any valid 
target supported by GDB, whether native or cross.  If you remove DJGPP 
from that list, it might cause someone to think DJGPP is no longer 
supported.

Note that I don't have anything against the change to config.tgt.

Re: [rfa/i386] Consolidate i386 targets

[Andrew Cagney]

> On Sun, 4 Aug 2002, Andrew Cagney wrote:
> 
> 
>> Yes, DJGPP is definitly still supported.  DJGPP is a native 
>> configuration though, and the above list applies to the cross debuggers.
> 
> 
> I think that might confuse someone (it did confuse me): there's only one 
> list of targets in MAINTAINERS, so I thought it pertains to any valid 
> target supported by GDB, whether native or cross.

Something to clarify, yes.  That list is just the target architectures 
-- i386, sh, ia64, et.al.

DJGPP while depending on the i386 architecture is a native so is listed 
under Host/Native.

>  If you remove DJGPP 
> from that list, it might cause someone to think DJGPP is no longer 
> supported.

Sounds like I should re-structure the file.  As an aside, RMS has noted 
that we should be using the correct GNU/Linux tuple name.

Hmm, given there are other redundant targets (rs6000) and targets with 
unfortunate names (s390-linux), I should overhaul the section.  The 
DJGPP change will then make more sense.

> Note that I don't have anything against the change to config.tgt.

I'll split that out.

Andrew