Re: Remove code handling old ARM aliases from GDB

["Joseph S. Myers" <joseph@codesourcery.com>]

On Thu, 5 May 2011, Hans-Peter Nilsson wrote:

> > -if { [istarget xscale*-*-*] } {
> > +if { [istarget arm*-*-*] } {

> How did you test these changes?

I considered them sufficiently obviously syntactically correct not to need 
testing.

> These changes broke testing for arm-elfo, on ang x86_64 host
> using current binutils CVS like so:

> FAIL: xscale wcmpgt.cgs (execution)
> FAIL: xscale wmac.cgs (execution)
> FAIL: xscale wsra.cgs (execution)

> WARNING: program timed out.
> FAIL: xscale blx.cgs (execution)

I don't call that breaking testing; I call that exposing bugs (whether in 
the simulator or testsuite) that were previously hidden by the use of an 
obsolete target triplet name.  Since the simulator features do not depend 
on the target triplet name, it seems clear that these tests should be run 
for all ARM targets - and so it seems better to expose the problems by 
using a current target name than to make the formally no-op change of 
using if { 0 } to replace an always-false conditional.

If the issue were actually missing assembler or simulator options a lot 
more tests in those directories would fail, so it seems much more likely 
that the relevant simulator functionality has become bitrotten over time.

-- 
Joseph S. Myers
joseph@codesourcery.com