From: Hans-Peter Nilsson <hp@bitrange.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Remove code handling old ARM aliases from GDB
Date: Thu, 05 May 2011 13:21:00 -0000 [thread overview]
Message-ID: <alpine.BSF.2.00.1105050909260.23527@dair.pair.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1105041859230.1752@digraph.polyomino.org.uk>
On Wed, 4 May 2011, Joseph S. Myers wrote:
> sim/testsuite:
> 2011-05-04 Joseph Myers <joseph@codesourcery.com>
>
> * configure: Regenerate.
> * sim/arm/allinsn.exp (xscale*-*-*): Don't handle target.
> * sim/arm/misc.exp (thumb*-*-*, xscale*-*-*): Don't handle
> targets.
> * sim/arm/iwmmxt/iwmmxt.exp: Test for arm*-*-* instead of
> xscale*-*-*.
> * sim/arm/thumb/allthumb.exp (thumb*-*-*): Don't handle target.
> * sim/arm/xscale/xscale.exp: Test for arm*-*-* instead of
> xscale*-*-*.
> Index: sim/testsuite/sim/arm/iwmmxt/iwmmxt.exp
> ===================================================================
> RCS file: /cvs/src/src/sim/testsuite/sim/arm/iwmmxt/iwmmxt.exp,v
> retrieving revision 1.1
> diff -u -r1.1 iwmmxt.exp
> --- sim/testsuite/sim/arm/iwmmxt/iwmmxt.exp 1 Apr 2003 11:07:58 -0000 1.1
> +++ sim/testsuite/sim/arm/iwmmxt/iwmmxt.exp 4 May 2011 18:52:03 -0000
> @@ -1,6 +1,6 @@
> # Intel(r) Wireless MMX(tm) technology simulator testsuite.
>
> -if { [istarget xscale*-*-*] } {
> +if { [istarget arm*-*-*] } {
> # load support procs (none yet)
> # load_lib cgen.exp
> Index: sim/testsuite/sim/arm/xscale/xscale.exp
> ===================================================================
> RCS file: /cvs/src/src/sim/testsuite/sim/arm/xscale/xscale.exp,v
> retrieving revision 1.1
> diff -u -r1.1 xscale.exp
> --- sim/testsuite/sim/arm/xscale/xscale.exp 1 Apr 2003 11:07:58 -0000 1.1
> +++ sim/testsuite/sim/arm/xscale/xscale.exp 4 May 2011 18:52:03 -0000
> @@ -1,6 +1,6 @@
> # XSCALE simulator testsuite.
>
> -if { [istarget xscale*-*-*] } {
> +if { [istarget arm*-*-*] } {
> # load support procs (none yet)
> # load_lib cgen.exp
How did you test these changes?
These changes broke testing for arm-elfo, on ang x86_64 host
using current binutils CVS like so:
Schedule of variations:
arm-sim
Running target arm-sim
Using /usr/share/dejagnu/baseboards/arm-sim.exp as board description file for target.
Using /usr/share/dejagnu/config/sim.exp as generic interface file for target.
Using /usr/share/dejagnu/baseboards/basic-sim.exp as board description file for target.
Using /tmp/hpautotest-sim/src/sim/testsuite/config/default.exp
as tool-and-target-specific interface file.
Running /tmp/hpautotest-sim/src/sim/testsuite/sim/arm/allinsn.exp ...
Running /tmp/hpautotest-sim/src/sim/testsuite/sim/arm/iwmmxt/iwmmxt.exp ...
FAIL: xscale wcmpgt.cgs (execution)
FAIL: xscale wmac.cgs (execution)
FAIL: xscale wsra.cgs (execution)
Running /tmp/hpautotest-sim/src/sim/testsuite/sim/arm/misc.exp ...
Running /tmp/hpautotest-sim/src/sim/testsuite/sim/arm/thumb/allthumb.exp ...
Running /tmp/hpautotest-sim/src/sim/testsuite/sim/arm/xscale/xscale.exp ...
WARNING: program timed out.
FAIL: xscale blx.cgs (execution)
Please fix, suggesting by adding needed options to the assembler
and sim invocations. I don't know if src/sim can handle
whatever is tested by iwmmxt.exp and xscale.exp, but if it can't
at all (i.e. these tests are not intended to be run with src/sim
but with real hw or qemu), an alternative would be to
sufficiently gate the tests. If all else fails, reverting your
change is an option.
brgds, H-P
next prev parent reply other threads:[~2011-05-05 13:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 19:01 Joseph S. Myers
2011-05-04 19:21 ` Mark Kettenis
2011-05-04 19:23 ` Pedro Alves
2011-05-04 19:24 ` Pedro Alves
2011-05-05 13:21 ` Hans-Peter Nilsson [this message]
2011-05-05 13:47 ` Hans-Peter Nilsson
2011-05-05 14:34 ` Joseph S. Myers
2011-05-05 22:11 ` Hans-Peter Nilsson
2011-05-05 22:34 ` Joseph S. Myers
2011-05-05 23:06 ` Hans-Peter Nilsson
2011-05-05 23:19 ` Joseph S. Myers
2011-05-05 23:52 ` Joseph S. Myers
2011-05-06 0:23 ` Joel Brobecker
2011-05-06 3:00 ` Hans-Peter Nilsson
[not found] ` <Pine.LNX.4.64.1105052349190.20285@digraph.polyomino.org.uk>
2011-05-09 4:53 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.00.1105050909260.23527@dair.pair.com \
--to=hp@bitrange.com \
--cc=gdb-patches@sourceware.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox