Re: Remove code handling old ARM aliases from GDB

[Hans-Peter Nilsson <hp@bitrange.com>]

On Thu, 5 May 2011, Joseph S. Myers wrote:
> On Thu, 5 May 2011, Hans-Peter Nilsson wrote:
>
> > > -if { [istarget xscale*-*-*] } {
> > > +if { [istarget arm*-*-*] } {
>
> > How did you test these changes?
>
> I considered them sufficiently obviously syntactically correct not to need
> testing.

It might have seemed like that at the time, but obviously it
wasn't so.

> > These changes broke testing for arm-elfo, on ang x86_64 host
> > using current binutils CVS like so:
>
> > FAIL: xscale wcmpgt.cgs (execution)
> > FAIL: xscale wmac.cgs (execution)
> > FAIL: xscale wsra.cgs (execution)
>
> > WARNING: program timed out.
> > FAIL: xscale blx.cgs (execution)
>
> I don't call that breaking testing; I call that exposing bugs (whether in
> the simulator or testsuite) that were previously hidden by the use of an
> obsolete target triplet name.

arm-elf passed before and does not anymore after those changes.
That's breaking testing.  Any other definition falls prey to
"latent bugs" weaseling.

If you can't invest the time to verify whether there are indeed
options missing, I'd be ok with an "if { 0 }" replacement plus a
big comment.  It'd also be prudent to open a PR (obviously
timing out is a bad choice unless that's what the default ARM
target hw would do).  I unfortunately doubt we have a
sufficiently interested target maintainer for src/sim/arm.

brgds, H-P