From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2141 invoked by alias); 5 May 2011 14:34:37 -0000 Received: (qmail 2066 invoked by uid 22791); 5 May 2011 14:34:35 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 May 2011 14:34:21 +0000 Received: (qmail 31335 invoked from network); 5 May 2011 14:34:20 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 May 2011 14:34:20 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1QHzdD-0004Km-4Q; Thu, 05 May 2011 14:34:19 +0000 Date: Thu, 05 May 2011 14:34:00 -0000 From: "Joseph S. Myers" To: Hans-Peter Nilsson cc: gdb-patches@sourceware.org Subject: Re: Remove code handling old ARM aliases from GDB In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00131.txt.bz2 On Thu, 5 May 2011, Hans-Peter Nilsson wrote: > > -if { [istarget xscale*-*-*] } { > > +if { [istarget arm*-*-*] } { > How did you test these changes? I considered them sufficiently obviously syntactically correct not to need testing. > These changes broke testing for arm-elfo, on ang x86_64 host > using current binutils CVS like so: > FAIL: xscale wcmpgt.cgs (execution) > FAIL: xscale wmac.cgs (execution) > FAIL: xscale wsra.cgs (execution) > WARNING: program timed out. > FAIL: xscale blx.cgs (execution) I don't call that breaking testing; I call that exposing bugs (whether in the simulator or testsuite) that were previously hidden by the use of an obsolete target triplet name. Since the simulator features do not depend on the target triplet name, it seems clear that these tests should be run for all ARM targets - and so it seems better to expose the problems by using a current target name than to make the formally no-op change of using if { 0 } to replace an always-false conditional. If the issue were actually missing assembler or simulator options a lot more tests in those directories would fail, so it seems much more likely that the relevant simulator functionality has become bitrotten over time. -- Joseph S. Myers joseph@codesourcery.com