From: Wu Zhou <woodzltc@cn.ibm.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Is this kind of patch welcomed?
Date: Sun, 29 May 2005 06:11:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.63.0505290516430.27903@plinuxt18.cn.ibm.com> (raw)
In-Reply-To: <20050528185650.GI26806@nevyn.them.org>
On Sat, 28 May 2005, Daniel Jacobowitz wrote:
> I've committed it with this ChangeLog:
> 2005-05-28 Daniel Jacobowitz <dan@codesourcery.com>
>
> From Wu Zhou <woodzltc@cn.ibm.com>:
> * remote.c (struct gdb_ext_thread_info): Fix a comment typo.
> (remote_unpack_thread_info_response): Likewise.
Thanks for commiting this. BTW, could I get the Write After Approval
access? It is said that I need a valid FSF assignment and had ever
submitted one good patch. Who could recommend me for this? Thanks a
lot!
>
> [The comments are still formatted badly, but that's no excuse not to
> fix the spelling!]
>
OK. What is the good style for the comments? I guess that you might
means that the first comment should be in one line other than the code,
and the second comment should set its first character in uppercase,
right? I'd like to code another patch if you tell me what is the right
format. Thanks.
Cheers
- Wu Zhou
next prev parent reply other threads:[~2005-05-29 4:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-24 13:04 Wu Zhou
2005-05-24 14:11 ` Daniel Jacobowitz
2005-05-25 6:48 ` Wu Zhou
2005-05-28 22:18 ` Daniel Jacobowitz
2005-05-29 6:11 ` Wu Zhou [this message]
2005-05-29 14:21 ` Daniel Jacobowitz
2005-05-29 17:48 ` Wu Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.63.0505290516430.27903@plinuxt18.cn.ibm.com \
--to=woodzltc@cn.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox