From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19325 invoked by alias); 29 May 2005 04:57:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19310 invoked by uid 22791); 29 May 2005 04:57:06 -0000 Received: from ausmtp02.au.ibm.com (HELO ausmtp02.au.ibm.com) (202.81.18.187) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 29 May 2005 04:57:06 +0000 Received: from sd0208e0.au.ibm.com (d23rh904.au.ibm.com [202.81.18.202]) by ausmtp02.au.ibm.com (8.12.10/8.12.10) with ESMTP id j4T4qf2F415900 for ; Sun, 29 May 2005 14:52:44 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.250.244]) by sd0208e0.au.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j4T4xoCZ089550 for ; Sun, 29 May 2005 14:59:50 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.12.11/8.13.3) with ESMTP id j4T4uuG2018095 for ; Sun, 29 May 2005 14:56:57 +1000 Received: from plinuxt18.cn.ibm.com (plinuxt18.cn.ibm.com [9.181.140.28]) by d23av03.au.ibm.com (8.12.11/8.12.11) with ESMTP id j4T4utcS018086; Sun, 29 May 2005 14:56:56 +1000 Date: Sun, 29 May 2005 06:11:00 -0000 From: Wu Zhou To: Daniel Jacobowitz cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Is this kind of patch welcomed? In-Reply-To: <20050528185650.GI26806@nevyn.them.org> Message-ID: References: <20050524130425.GA1543@nevyn.them.org> <20050528185650.GI26806@nevyn.them.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-05/txt/msg00608.txt.bz2 On Sat, 28 May 2005, Daniel Jacobowitz wrote: > I've committed it with this ChangeLog: > 2005-05-28 Daniel Jacobowitz > > From Wu Zhou : > * remote.c (struct gdb_ext_thread_info): Fix a comment typo. > (remote_unpack_thread_info_response): Likewise. Thanks for commiting this. BTW, could I get the Write After Approval access? It is said that I need a valid FSF assignment and had ever submitted one good patch. Who could recommend me for this? Thanks a lot! > > [The comments are still formatted badly, but that's no excuse not to > fix the spelling!] > OK. What is the good style for the comments? I guess that you might means that the first comment should be in one line other than the code, and the second comment should set its first character in uppercase, right? I'd like to code another patch if you tell me what is the right format. Thanks. Cheers - Wu Zhou