Re: [RFC] Is this kind of patch welcomed?

[Daniel Jacobowitz <drow@false.org>]

On Sun, May 29, 2005 at 05:53:05AM -0700, Wu Zhou wrote:
> On Sat, 28 May 2005, Daniel Jacobowitz wrote:
> 
> > I've committed it with this ChangeLog:
> > 2005-05-28  Daniel Jacobowitz  <dan@codesourcery.com>
> > 
> >         From Wu Zhou <woodzltc@cn.ibm.com>:
> >         * remote.c (struct gdb_ext_thread_info): Fix a comment typo.
> >         (remote_unpack_thread_info_response): Likewise.
> 
> Thanks for commiting this.  BTW, could I get the Write After Approval
> access?  It is said that I need a valid FSF assignment and had ever 
> submitted one good patch.  Who could recommend me for this? Thanks a
> lot!

Please fill out the form here:
  http://sourceware.org/cgi-bin/pdw/ps_form.cgi

List me as the approver.

> > [The comments are still formatted badly, but that's no excuse not to
> > fix the spelling!]
> > 
> 
> OK.  What is the good style for the comments?  I guess that you might
> means that the first comment should be in one line other than the code,
> and the second comment should set its first character in uppercase, 
> right?  I'd like to code another patch if you tell me what is the right
> format.  Thanks.

Don't worry about it for now.  The file is full of similar comments;
fixing one or two isn't a big deal.  Eventually someone should go
through and proof the whole thing.  Comments are supposed to be
sentences, capitalized, with a period and two spaces at the end; we
generally ignore the full sentences bit, since it's awkwardly wordy,
but the formatting is still important.

-- 
Daniel Jacobowitz
CodeSourcery, LLC