Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Wu Zhou <woodzltc@cn.ibm.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Is this kind of patch welcomed?
Date: Sat, 28 May 2005 22:18:00 -0000	[thread overview]
Message-ID: <20050528185650.GI26806@nevyn.them.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0505250455510.1089@plinuxt18.cn.ibm.com>

On Wed, May 25, 2005 at 06:33:01AM -0700, Wu Zhou wrote:
> 
> OK.  Followed is the revised patch: another typo is fixed and changlog
> entry added. 
> 
> 2005-05-25  Wu Zhou  <woodzltc@cn.ibm.com>
> 
> 	* remote.c: Fix two comment typos

Period at the end of changelog entries.  Also, you need to say where
you did it.

I've committed it with this ChangeLog:
2005-05-28  Daniel Jacobowitz  <dan@codesourcery.com>

        From Wu Zhou <woodzltc@cn.ibm.com>:
        * remote.c (struct gdb_ext_thread_info): Fix a comment typo.
        (remote_unpack_thread_info_response): Likewise.

[The comments are still formatted badly, but that's no excuse not to
fix the spelling!]

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  reply	other threads:[~2005-05-28 18:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-24 13:04 Wu Zhou
2005-05-24 14:11 ` Daniel Jacobowitz
2005-05-25  6:48   ` Wu Zhou
2005-05-28 22:18     ` Daniel Jacobowitz [this message]
2005-05-29  6:11       ` Wu Zhou
2005-05-29 14:21         ` Daniel Jacobowitz
2005-05-29 17:48           ` Wu Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050528185650.GI26806@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=woodzltc@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox