From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27022 invoked by alias); 29 May 2005 14:11:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27012 invoked by uid 22791); 29 May 2005 14:11:54 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 29 May 2005 14:11:54 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DcOVj-0006GJ-Pl; Sun, 29 May 2005 10:11:28 -0400 Date: Sun, 29 May 2005 14:21:00 -0000 From: Daniel Jacobowitz To: Wu Zhou Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Is this kind of patch welcomed? Message-ID: <20050529141127.GA23858@nevyn.them.org> Mail-Followup-To: Wu Zhou , gdb-patches@sources.redhat.com References: <20050524130425.GA1543@nevyn.them.org> <20050528185650.GI26806@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00615.txt.bz2 On Sun, May 29, 2005 at 05:53:05AM -0700, Wu Zhou wrote: > On Sat, 28 May 2005, Daniel Jacobowitz wrote: > > > I've committed it with this ChangeLog: > > 2005-05-28 Daniel Jacobowitz > > > > From Wu Zhou : > > * remote.c (struct gdb_ext_thread_info): Fix a comment typo. > > (remote_unpack_thread_info_response): Likewise. > > Thanks for commiting this. BTW, could I get the Write After Approval > access? It is said that I need a valid FSF assignment and had ever > submitted one good patch. Who could recommend me for this? Thanks a > lot! Please fill out the form here: http://sourceware.org/cgi-bin/pdw/ps_form.cgi List me as the approver. > > [The comments are still formatted badly, but that's no excuse not to > > fix the spelling!] > > > > OK. What is the good style for the comments? I guess that you might > means that the first comment should be in one line other than the code, > and the second comment should set its first character in uppercase, > right? I'd like to code another patch if you tell me what is the right > format. Thanks. Don't worry about it for now. The file is full of similar comments; fixing one or two isn't a big deal. Eventually someone should go through and proof the whole thing. Comments are supposed to be sentences, capitalized, with a period and two spaces at the end; we generally ignore the full sentences bit, since it's awkwardly wordy, but the formatting is still important. -- Daniel Jacobowitz CodeSourcery, LLC