* target.h (target_find_new_threads): Fix definition
@ 2007-12-04 13:55 Maciej W. Rozycki
2007-12-04 14:06 ` Daniel Jacobowitz
0 siblings, 1 reply; 2+ messages in thread
From: Maciej W. Rozycki @ 2007-12-04 13:55 UTC (permalink / raw)
To: gdb-patches; +Cc: Maciej W. Rozycki
Hello,
The definition of the target_find_new_threads() macro contains a trailing
semicolon which may lead to effects surprising to the reader if used as a
part of a control-flow statement and possibly elsewhere. This is not
currently the case, but it may be so in the future and it is not an excuse
either way.
Tested using the mipsisa32-sde-elf target, with the mips-sim-sde32/-EB
and mips-sim-sde32/-EL boards with no regressions.
2007-12-04 Maciej W. Rozycki <macro@mips.com>
* target.h (target_find_new_threads): Fix definition.
OK to apply?
Maciej
13327-0.diff
Index: binutils-quilt/src/gdb/target.h
===================================================================
--- binutils-quilt.orig/src/gdb/target.h 2007-12-03 14:20:57.000000000 +0000
+++ binutils-quilt/src/gdb/target.h 2007-12-03 14:28:21.000000000 +0000
@@ -886,7 +886,7 @@
/* Query for new threads and add them to the thread list. */
#define target_find_new_threads() \
- (*current_target.to_find_new_threads) (); \
+ (*current_target.to_find_new_threads) ()
/* Make target stop in a continuable fashion. (For instance, under
Unix, this should act like SIGSTOP). This function is normally
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: target.h (target_find_new_threads): Fix definition
2007-12-04 13:55 target.h (target_find_new_threads): Fix definition Maciej W. Rozycki
@ 2007-12-04 14:06 ` Daniel Jacobowitz
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Jacobowitz @ 2007-12-04 14:06 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: gdb-patches, Maciej W. Rozycki
On Tue, Dec 04, 2007 at 01:54:52PM +0000, Maciej W. Rozycki wrote:
> 2007-12-04 Maciej W. Rozycki <macro@mips.com>
>
> * target.h (target_find_new_threads): Fix definition.
>
> OK to apply?
Yes, thanks.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-04 14:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-04 13:55 target.h (target_find_new_threads): Fix definition Maciej W. Rozycki
2007-12-04 14:06 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox