From: "Maciej W. Rozycki" <macro@mips.com>
To: gdb-patches@sourceware.org
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: target.h (target_find_new_threads): Fix definition
Date: Tue, 04 Dec 2007 13:55:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.61.0712041333090.21152@perivale.mips.com> (raw)
Hello,
The definition of the target_find_new_threads() macro contains a trailing
semicolon which may lead to effects surprising to the reader if used as a
part of a control-flow statement and possibly elsewhere. This is not
currently the case, but it may be so in the future and it is not an excuse
either way.
Tested using the mipsisa32-sde-elf target, with the mips-sim-sde32/-EB
and mips-sim-sde32/-EL boards with no regressions.
2007-12-04 Maciej W. Rozycki <macro@mips.com>
* target.h (target_find_new_threads): Fix definition.
OK to apply?
Maciej
13327-0.diff
Index: binutils-quilt/src/gdb/target.h
===================================================================
--- binutils-quilt.orig/src/gdb/target.h 2007-12-03 14:20:57.000000000 +0000
+++ binutils-quilt/src/gdb/target.h 2007-12-03 14:28:21.000000000 +0000
@@ -886,7 +886,7 @@
/* Query for new threads and add them to the thread list. */
#define target_find_new_threads() \
- (*current_target.to_find_new_threads) (); \
+ (*current_target.to_find_new_threads) ()
/* Make target stop in a continuable fashion. (For instance, under
Unix, this should act like SIGSTOP). This function is normally
next reply other threads:[~2007-12-04 13:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 13:55 Maciej W. Rozycki [this message]
2007-12-04 14:06 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0712041333090.21152@perivale.mips.com \
--to=macro@mips.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox