From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8200 invoked by alias); 4 Dec 2007 13:55:10 -0000 Received: (qmail 8189 invoked by uid 22791); 4 Dec 2007 13:55:09 -0000 X-Spam-Check-By: sourceware.org Received: from dmz.mips-uk.com (HELO dmz.mips-uk.com) (194.74.144.194) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Dec 2007 13:55:00 +0000 Received: from internal-mx1 ([192.168.192.240] helo=ukservices1.mips.com) by dmz.mips-uk.com with esmtp (Exim 3.35 #1 (Debian)) id 1IzYEj-0007T8-00; Tue, 04 Dec 2007 13:54:57 +0000 Received: from perivale.mips.com ([192.168.192.200]) by ukservices1.mips.com with esmtp (Exim 3.36 #1 (Debian)) id 1IzYEe-0001MP-00; Tue, 04 Dec 2007 13:54:52 +0000 Received: from macro (helo=localhost) by perivale.mips.com with local-esmtp (Exim 4.63) (envelope-from ) id 1IzYEe-0003pR-Ba; Tue, 04 Dec 2007 13:54:52 +0000 Date: Tue, 04 Dec 2007 13:55:00 -0000 From: "Maciej W. Rozycki" To: gdb-patches@sourceware.org cc: "Maciej W. Rozycki" Subject: target.h (target_find_new_threads): Fix definition Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-MIPS-Technologies-UK-MailScanner: Found to be clean X-MIPS-Technologies-UK-MailScanner-From: macro@mips.com Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00051.txt.bz2 Hello, The definition of the target_find_new_threads() macro contains a trailing semicolon which may lead to effects surprising to the reader if used as a part of a control-flow statement and possibly elsewhere. This is not currently the case, but it may be so in the future and it is not an excuse either way. Tested using the mipsisa32-sde-elf target, with the mips-sim-sde32/-EB and mips-sim-sde32/-EL boards with no regressions. 2007-12-04 Maciej W. Rozycki * target.h (target_find_new_threads): Fix definition. OK to apply? Maciej 13327-0.diff Index: binutils-quilt/src/gdb/target.h =================================================================== --- binutils-quilt.orig/src/gdb/target.h 2007-12-03 14:20:57.000000000 +0000 +++ binutils-quilt/src/gdb/target.h 2007-12-03 14:28:21.000000000 +0000 @@ -886,7 +886,7 @@ /* Query for new threads and add them to the thread list. */ #define target_find_new_threads() \ - (*current_target.to_find_new_threads) (); \ + (*current_target.to_find_new_threads) () /* Make target stop in a continuable fashion. (For instance, under Unix, this should act like SIGSTOP). This function is normally