Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Manoj Iyer <manjo@austin.ibm.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] gdb.base/float.exp and gdb.base/commands.exp patch
Date: Mon, 07 Mar 2005 19:42:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.58.0503071325230.18123@lazy> (raw)
In-Reply-To: <20050307165807.GA11032@nevyn.them.org>

> > If I change the current value of 57 to 82, the test will pass in powerpc
> > but fail on intel. Coz the generated line numbers on intel(57) and
> > PowerPC(82) are different.
>
> That's why you should accept both of them.
>


Here is the patch accepting both values.

------------------ patch -----------------------
diff -Naurp ./old/src/gdb/testsuite/gdb.base/commands.exp
./new/src/gdb/testsuite/gdb.base/commands.exp
--- ./old/src/gdb/testsuite/gdb.base/commands.exp       2005-03-07
13:19:16.000000000 -0600
+++ ./new/src/gdb/testsuite/gdb.base/commands.exp       2005-03-07
13:21:49.000000000 -0600
@@ -331,7 +331,7 @@ proc watchpoint_command_test {} {
     }
     send_gdb "continue\n"
     gdb_expect {
-       -re "Continuing.*\[Ww\]atchpoint $wp_id deleted because the
program has left the block in.*which its expression is
valid.*run.c:57.*$gdb_prompt $" {
+       -re "Continuing.*\[Ww\]atchpoint $wp_id deleted because the
program has left the block in.*which its expression is
valid.*run.c:(57|82).*$gdb_prompt $" {
            pass "continue with watch"
        }
        -re "$gdb_prompt $"   {fail "continue with watch"}
------------------- end patch ----------------------


  reply	other threads:[~2005-03-07 19:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-02 23:55 Manoj Iyer
2005-03-03  0:27 ` Daniel Jacobowitz
2005-03-03  5:32   ` Manoj Iyer
2005-03-04 16:20     ` Manoj Iyer
2005-03-04 16:27     ` Daniel Jacobowitz
2005-03-07 16:55       ` Manoj Iyer
2005-03-07 16:58         ` Daniel Jacobowitz
2005-03-07 19:42           ` Manoj Iyer [this message]
2005-03-07 19:44             ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0503071325230.18123@lazy \
    --to=manjo@austin.ibm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox