Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Manoj Iyer <manjo@austin.ibm.com>
To: gdb-patches@sources.redhat.com
Subject: [RFC] gdb.base/float.exp and gdb.base/commands.exp patch
Date: Wed, 02 Mar 2005 23:55:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.58.0503021732360.3374@lazy> (raw)


Two testcases float.exp and commands.exp were failing on PowerPC for
simple reasons, command.exp had a hard coded line number and float.exp did
not have PowerPC as a known target. Please approve patch so that I can
commit. Here is the patch.



2005-03-02  Manoj Iyer  <manjo@austin.ibm.com>

	* commands.exp: Change hardcoded value to regular expression.
	* float.exp: Add powerpc to the list of targets checked.

------------------------------------------------------------------------------
diff -Naurp old/src/gdb/testsuite/gdb.base/commands.exp
new/src/gdb/testsuite/gdb.base/commands.exp
--- old/src/gdb/testsuite/gdb.base/commands.exp 2003-09-29
10:08:52.000000000 -0500
+++ new/src/gdb/testsuite/gdb.base/commands.exp 2005-03-23
08:18:41.000000000 -0600
@@ -331,7 +331,7 @@ proc watchpoint_command_test {} {
     }
     send_gdb "continue\n"
     gdb_expect {
-       -re "Continuing.*\[Ww\]atchpoint $wp_id deleted because the
program has left the block in.*which its expression is
valid.*run.c:57.*$gdb_prompt $" {
+       -re "Continuing.*\[Ww\]atchpoint $wp_id deleted because the
program has left the block in.*which its expression is
valid.*run.c:\[0-9\]+.*$gdb_prompt $" {
            pass "continue with watch"
        }
        -re "$gdb_prompt $"   {fail "continue with watch"}
diff -Naurp old/src/gdb/testsuite/gdb.base/float.exp
new/src/gdb/testsuite/gdb.base/float.exp
--- old/src/gdb/testsuite/gdb.base/float.exp    2004-06-08
10:50:59.000000000 -0500
+++ new/src/gdb/testsuite/gdb.base/float.exp    2005-03-23
08:19:38.000000000 -0600
@@ -65,6 +65,8 @@ if { [istarget "alpha*-*-*"] } then {
     gdb_test "info float" "fp0.*fp1.*fp7.*" "info float"
 } elseif [istarget "mips*-*-*"] then {
     gdb_test "info float" "f0:.*flt:.*dbl:.*" "info float"
+} elseif [istarget "powerpc*-*-*"] then {
+    gdb_test "info float" "f0.*f1.*f31.*fpscr.*" "info float"
 } elseif [istarget "s390*-*-*"] then {
     gdb_test "info float" "fpc.*f0.*f1.*f15.*" "info float"
 } elseif [istarget "sh*-*"] then {

----------------------------------------------------------------------------


Ok to commit??

-----
manjo
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ Cogito ergo sum                                                          +
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++


             reply	other threads:[~2005-03-02 23:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-02 23:55 Manoj Iyer [this message]
2005-03-03  0:27 ` Daniel Jacobowitz
2005-03-03  5:32   ` Manoj Iyer
2005-03-04 16:20     ` Manoj Iyer
2005-03-04 16:27     ` Daniel Jacobowitz
2005-03-07 16:55       ` Manoj Iyer
2005-03-07 16:58         ` Daniel Jacobowitz
2005-03-07 19:42           ` Manoj Iyer
2005-03-07 19:44             ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0503021732360.3374@lazy \
    --to=manjo@austin.ibm.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox