From: Daniel Jacobowitz <drow@false.org>
To: Manoj Iyer <manjo@austin.ibm.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] gdb.base/float.exp and gdb.base/commands.exp patch
Date: Mon, 07 Mar 2005 16:58:00 -0000 [thread overview]
Message-ID: <20050307165807.GA11032@nevyn.them.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0503071034530.15625@lazy>
On Mon, Mar 07, 2005 at 10:39:32AM -0600, Manoj Iyer wrote:
> >
> > Accepting any line number is not OK. Accepting this particular line
> > number does seem plausible. Can you do that instead?
> >
>
> If I change the current value of 57 to 82, the test will pass in powerpc
> but fail on intel. Coz the generated line numbers on intel(57) and
> PowerPC(82) are different.
That's why you should accept both of them.
> > I've done it in the past. It's not that hard to get ahold of one.
> > But, as I said, I do not know what will be output.
> > Might as well do this for now and fix it up later.
> >
>
> So, does that mean you accept the patch to float.exp? Or are we still
> worried about ppc32 nofpu?
I think it's OK. Please post the patch + changelog for just float.exp,
and check that in.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-03-07 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 23:55 Manoj Iyer
2005-03-03 0:27 ` Daniel Jacobowitz
2005-03-03 5:32 ` Manoj Iyer
2005-03-04 16:20 ` Manoj Iyer
2005-03-04 16:27 ` Daniel Jacobowitz
2005-03-07 16:55 ` Manoj Iyer
2005-03-07 16:58 ` Daniel Jacobowitz [this message]
2005-03-07 19:42 ` Manoj Iyer
2005-03-07 19:44 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050307165807.GA11032@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=manjo@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox