From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19672 invoked by alias); 2 Mar 2005 23:55:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19627 invoked from network); 2 Mar 2005 23:54:50 -0000 Received: from unknown (HELO e35.co.us.ibm.com) (32.97.110.133) by sourceware.org with SMTP; 2 Mar 2005 23:54:50 -0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e35.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j22NsnLg302524 for ; Wed, 2 Mar 2005 18:54:49 -0500 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j22NsnXV169668 for ; Wed, 2 Mar 2005 16:54:49 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j22NsmOA000743 for ; Wed, 2 Mar 2005 16:54:49 -0700 Received: from austin.ibm.com (netmail2.austin.ibm.com [9.41.248.176]) by d03av02.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j22NsmSm000732 for ; Wed, 2 Mar 2005 16:54:48 -0700 Received: from lazy.austin.ibm.com (lazy.austin.ibm.com [9.53.94.97]) by austin.ibm.com (8.12.10/8.12.10) with ESMTP id j22NsmRZ176306 for ; Wed, 2 Mar 2005 17:54:48 -0600 Date: Wed, 02 Mar 2005 23:55:00 -0000 From: Manoj Iyer X-X-Sender: manjo@lazy To: gdb-patches@sources.redhat.com Subject: [RFC] gdb.base/float.exp and gdb.base/commands.exp patch Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-03/txt/msg00022.txt.bz2 Two testcases float.exp and commands.exp were failing on PowerPC for simple reasons, command.exp had a hard coded line number and float.exp did not have PowerPC as a known target. Please approve patch so that I can commit. Here is the patch. 2005-03-02 Manoj Iyer * commands.exp: Change hardcoded value to regular expression. * float.exp: Add powerpc to the list of targets checked. ------------------------------------------------------------------------------ diff -Naurp old/src/gdb/testsuite/gdb.base/commands.exp new/src/gdb/testsuite/gdb.base/commands.exp --- old/src/gdb/testsuite/gdb.base/commands.exp 2003-09-29 10:08:52.000000000 -0500 +++ new/src/gdb/testsuite/gdb.base/commands.exp 2005-03-23 08:18:41.000000000 -0600 @@ -331,7 +331,7 @@ proc watchpoint_command_test {} { } send_gdb "continue\n" gdb_expect { - -re "Continuing.*\[Ww\]atchpoint $wp_id deleted because the program has left the block in.*which its expression is valid.*run.c:57.*$gdb_prompt $" { + -re "Continuing.*\[Ww\]atchpoint $wp_id deleted because the program has left the block in.*which its expression is valid.*run.c:\[0-9\]+.*$gdb_prompt $" { pass "continue with watch" } -re "$gdb_prompt $" {fail "continue with watch"} diff -Naurp old/src/gdb/testsuite/gdb.base/float.exp new/src/gdb/testsuite/gdb.base/float.exp --- old/src/gdb/testsuite/gdb.base/float.exp 2004-06-08 10:50:59.000000000 -0500 +++ new/src/gdb/testsuite/gdb.base/float.exp 2005-03-23 08:19:38.000000000 -0600 @@ -65,6 +65,8 @@ if { [istarget "alpha*-*-*"] } then { gdb_test "info float" "fp0.*fp1.*fp7.*" "info float" } elseif [istarget "mips*-*-*"] then { gdb_test "info float" "f0:.*flt:.*dbl:.*" "info float" +} elseif [istarget "powerpc*-*-*"] then { + gdb_test "info float" "f0.*f1.*f31.*fpscr.*" "info float" } elseif [istarget "s390*-*-*"] then { gdb_test "info float" "fpc.*f0.*f1.*f15.*" "info float" } elseif [istarget "sh*-*"] then { ---------------------------------------------------------------------------- Ok to commit?? ----- manjo +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ + Cogito ergo sum + +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++