From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-38320-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 19817 invoked by alias); 7 Mar 2005 19:42:05 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 19791 invoked from network); 7 Mar 2005 19:42:01 -0000
Received: from unknown (HELO e33.co.us.ibm.com) (32.97.110.131)
  by sourceware.org with SMTP; 7 Mar 2005 19:42:01 -0000
Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11])
	by e33.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j27JfuTE467112
	for <gdb-patches@sources.redhat.com>; Mon, 7 Mar 2005 14:41:59 -0500
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by westrelay02.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j27JftL1178884
	for <gdb-patches@sources.redhat.com>; Mon, 7 Mar 2005 12:41:55 -0700
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j27Jftro031236
	for <gdb-patches@sources.redhat.com>; Mon, 7 Mar 2005 12:41:55 -0700
Received: from austin.ibm.com (netmail2.austin.ibm.com [9.41.248.176])
	by d03av02.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j27JftIn031204;
	Mon, 7 Mar 2005 12:41:55 -0700
Received: from lazy.austin.ibm.com (lazy.austin.ibm.com [9.53.94.97])
	by austin.ibm.com (8.12.10/8.12.10) with ESMTP id j27Jfsfx029058;
	Mon, 7 Mar 2005 13:41:54 -0600
Date: Mon, 07 Mar 2005 19:42:00 -0000
From: Manoj Iyer <manjo@austin.ibm.com>
X-X-Sender: manjo@lazy
To: Daniel Jacobowitz <drow@false.org>
cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] gdb.base/float.exp and gdb.base/commands.exp patch
In-Reply-To: <20050307165807.GA11032@nevyn.them.org>
Message-ID: <Pine.LNX.4.58.0503071325230.18123@lazy>
References: <Pine.LNX.4.58.0503021732360.3374@lazy> <20050303002718.GA4915@nevyn.them.org>
 <Pine.LNX.4.58.0503022307480.5029@lazy> <20050304162656.GA3334@nevyn.them.org>
 <Pine.LNX.4.58.0503071034530.15625@lazy> <20050307165807.GA11032@nevyn.them.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2005-03/txt/msg00083.txt.bz2

> > If I change the current value of 57 to 82, the test will pass in powerpc
> > but fail on intel. Coz the generated line numbers on intel(57) and
> > PowerPC(82) are different.
>
> That's why you should accept both of them.
>


Here is the patch accepting both values.

------------------ patch -----------------------
diff -Naurp ./old/src/gdb/testsuite/gdb.base/commands.exp
./new/src/gdb/testsuite/gdb.base/commands.exp
--- ./old/src/gdb/testsuite/gdb.base/commands.exp       2005-03-07
13:19:16.000000000 -0600
+++ ./new/src/gdb/testsuite/gdb.base/commands.exp       2005-03-07
13:21:49.000000000 -0600
@@ -331,7 +331,7 @@ proc watchpoint_command_test {} {
     }
     send_gdb "continue\n"
     gdb_expect {
-       -re "Continuing.*\[Ww\]atchpoint $wp_id deleted because the
program has left the block in.*which its expression is
valid.*run.c:57.*$gdb_prompt $" {
+       -re "Continuing.*\[Ww\]atchpoint $wp_id deleted because the
program has left the block in.*which its expression is
valid.*run.c:(57|82).*$gdb_prompt $" {
            pass "continue with watch"
        }
        -re "$gdb_prompt $"   {fail "continue with watch"}
------------------- end patch ----------------------