[patch/testsuite/mi/copyright] gdb.mi/mi2-*.exp: update copyright years

[patch/testsuite/mi/copyright] gdb.mi/mi2-*.exp: update copyright years

[Michael Chastain]

This is tedious copyright patch #2 of 2 for gdb.mi/*.exp.

Date sources:

  gdb/testsuite/ChangeLog
  gdb/testsuite/gdb.mi/ChangeLog-1999-2003
  cvs history
  the dates in the base files gdb.mi/mi*-exp.

Tested on native i686-pc-linux-gnu just in case the tcl comment
character mutated while I wasn't looking.

This patch was pre-approved by Andrew Cagney, so I am committing
it now.

Michael C

2004-08-09  Michael Chastain  <mec.gnu@mindspring.com>

	* gdb.mi/mi2-basics.exp, gdb.mi/mi2-break.exp,
	gdb.mi/mi2-console.exp, gdb.mi/mi2-disassemble.exp,
	gdb.mi/mi2-eval.exp, gdb.mi/mi2-file.exp, gdb.mi/mi2-hack-cli.exp,
	gdb.mi/mi2-read-memory.exp, gdb.mi/mi2-regs.exp,
	gdb.mi/mi2-return.exp, gdb.mi/mi2-simplerun.exp,
	gdb.mi/mi2-stack.exp, gdb.mi/mi2-stepi.exp, gdb.mi/mi2-until.exp,
	gdb.mi/mi2-var-block.exp, gdb.mi/mi2-var-child.exp,
	gdb.mi/mi2-var-cmd.exp, gdb.mi/mi2-var-display.exp,
	gdb.mi/mi2-watch.exp: Update copyright years.

Index: gdb.mi/mi2-basics.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-basics.exp,v
retrieving revision 1.2
diff -c -3 -p -r1.2 mi2-basics.exp
*** gdb.mi/mi2-basics.exp	13 Jan 2004 00:25:28 -0000	1.2
--- gdb.mi/mi2-basics.exp	9 Aug 2004 17:54:03 -0000
***************
*** 1,4 ****
! # Copyright 1999, 2000, 2004 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,5 ----
! # Copyright 1999, 2000, 2001, 2002, 2003, 2004
! # Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-break.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-break.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-break.exp
*** gdb.mi/mi2-break.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-break.exp	9 Aug 2004 17:54:03 -0000
***************
*** 1,4 ****
! #   Copyright 1999 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2001, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-console.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-console.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-console.exp
*** gdb.mi/mi2-console.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-console.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! # Copyright 1999, 2000, 2001, 2002 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-disassemble.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-disassemble.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-disassemble.exp
*** gdb.mi/mi2-disassemble.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-disassemble.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! # Copyright 1999, 2000, 2002 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-eval.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-eval.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-eval.exp
*** gdb.mi/mi2-eval.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-eval.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! # Copyright 1999, 2000, 2002 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-file.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-file.exp,v
retrieving revision 1.3
diff -c -3 -p -r1.3 mi2-file.exp
*** gdb.mi/mi2-file.exp	8 Jul 2004 01:57:51 -0000	1.3
--- gdb.mi/mi2-file.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! #   Copyright 1999, 2004 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2003, 2004 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-hack-cli.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-hack-cli.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-hack-cli.exp
*** gdb.mi/mi2-hack-cli.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-hack-cli.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! #   Copyright 1999 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2001, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-read-memory.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-read-memory.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-read-memory.exp
*** gdb.mi/mi2-read-memory.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-read-memory.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! # Copyright 1999, 2000, 2002 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-regs.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-regs.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-regs.exp
*** gdb.mi/mi2-regs.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-regs.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! # Copyright 1999, 2000, 2002 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-return.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-return.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-return.exp
*** gdb.mi/mi2-return.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-return.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! # Copyright 1999, 2000, 2002 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-simplerun.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-simplerun.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-simplerun.exp
*** gdb.mi/mi2-simplerun.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-simplerun.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! #   Copyright 1999, 2000 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-stack.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-stack.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-stack.exp
*** gdb.mi/mi2-stack.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-stack.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! # Copyright 2000, 2002 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-stepi.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-stepi.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-stepi.exp
*** gdb.mi/mi2-stepi.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-stepi.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! # Copyright 1999, 2000, 2002 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-until.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-until.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-until.exp
*** gdb.mi/mi2-until.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-until.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! #   Copyright 1999, 2000 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-var-block.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-var-block.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-var-block.exp
*** gdb.mi/mi2-var-block.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-var-block.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! # Copyright (C) 1999, 2000, 2002 Free Software Foundation, Inc.
  #
  # This Program Is Free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  #
  # This Program Is Free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-var-child.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-var-child.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-var-child.exp
*** gdb.mi/mi2-var-child.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-var-child.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! #   Copyright (C) 1999, 2000, 2002 Free Software Foundation
  
  # This Program Is Free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2002, 2003 Free Software Foundation
  
  # This Program Is Free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-var-cmd.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-var-cmd.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-var-cmd.exp
*** gdb.mi/mi2-var-cmd.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-var-cmd.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! # Copyright (C) 1999, 2000, 2002 Free Software Foundation, Inc.
  #
  # This Program Is Free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  #
  # This Program Is Free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-var-display.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-var-display.exp,v
retrieving revision 1.2
diff -c -3 -p -r1.2 mi2-var-display.exp
*** gdb.mi/mi2-var-display.exp	17 Aug 2003 17:23:13 -0000	1.2
--- gdb.mi/mi2-var-display.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! #   Copyright (C) 1999, 2000, 2002 Free Software Foundation, Inc.
  #
  # This Program Is Free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  #
  # This Program Is Free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
Index: gdb.mi/mi2-watch.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-watch.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 mi2-watch.exp
*** gdb.mi/mi2-watch.exp	7 Aug 2003 17:47:42 -0000	1.1
--- gdb.mi/mi2-watch.exp	9 Aug 2004 17:54:04 -0000
***************
*** 1,4 ****
! # Copyright 1999, 2000, 2002 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by

[RFC] New thread testcase.

[Manoj Iyer]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1003 bytes --]


Please find attached a new thread test that tests GDB functions like
break, step etc from a thread function. This testcase uncovered a problem
in GDB32 on ppc64 machine due to a generic kernel bug in ptrace().

For example:

(gdb) break tf
Breakpoint 2 at 0x10000594: file tbug.c, line 15.
(gdb) run
Starting program: /home/public/test-tools/gdb/tbug
[Thread debugging using libthread_db enabled]
[New Thread 1074020384 (LWP 26710)]
reading register pc (#64): No such process.
(gdb) cont
Continuing.
reading register pc (#64): No such process.
(gdb) cont
Continuing.
reading register pc (#64): No such process.
(gdb) cont
Continuing.
reading register pc (#64): No such process.
(gdb) quit
The program is running.  Exit anyway? (y or n) y

Thanks
----- ----
Manoj Iyer
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ Cognito ergo sum                                                          +
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

[-- Attachment #2: C program --]
[-- Type: TEXT/x-csrc, Size: 1906 bytes --]

/*
* Copyright (C) 2004 Free Software Foundation, Inc.

* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.

* Please email any bugs, comments, and/or additions to this file to:
* bug-gdb@prep.ai.mit.edu

* This file was written by Steve Munroe. (sjmunroe@us.ibm.com)
* Test break points and single step on thread functions.
*/

#include <string.h>
#include <unistd.h>
#include <pthread.h>
#include <stdlib.h>
#include <stdio.h>
#include <errno.h>

#define N       2

static void *
tf (void *arg)
{
    int n = (int) (long int) arg;
    char number[160];
    sprintf(number, "tf(%ld): begin", (long)arg);
    puts (number);

    sleep (100);
    sprintf(number, "tf(%ld): end", (long)arg);
    puts (number);
    return NULL;
}

int main (int argc, char *argv[])
{
    int n;
    pthread_t th[N];

    for (n = 0; n < N; ++n)
    if (pthread_create (&th[n], NULL, tf, (void *) (long int) n) != 0)
    {
        sleep(2);
        puts ("create failed");
        exit (1);
    }

    puts("after create");

    for (n = 0; n < N; ++n)
    if (pthread_join (th[n], NULL) != 0)
    {
        puts ("join failed");
        exit (1);
    }

    puts("after join");
              return 0;
}

[-- Attachment #3: expect script --]
[-- Type: TEXT/PLAIN, Size: 3735 bytes --]

# Copyright (C) 2004 Free Software Foundation, Inc.

# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.

# Please email any bugs, comments, and/or additions to this file to:
# bug-gdb@prep.ai.mit.edu

# This file was written by Manoj Iyer. (manjo@austin.ibm.com)
# Test break points and single step on thread functions.
# 
# Test Purpose:
# - Test that breakpoints, single step, and bracktrace works on a threaded 
#   application. On ppc64 system this test is known to fail due to kernel bug 
#   in ptrace system call.
#
# Test Strategy:
# - tbug.c creates 2 threads
# - start gdb 
# - create 2 breakpoints #1 main() #2 tf() (the thread function)
# - run gdb till #1 main() breakpoint is reached
# - continue to breakpoint #2 tf()
# - single step to first instruction in the thread function tf()
# - backtrace from thread function tf()
# - delete all breakpoints 
# - exit gdb.

if $tracelevel then {
        strace $tracelevel
}

set prms_id 0
set bug_id 0

set testfile "tbug"
set srcfile ${testfile}.c
set binfile ${objdir}/${subdir}/${testfile}

if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list debug "incdir=${objdir}"]] != "" } {
    return -1
}

gdb_start
gdb_reinitialize_dir $srcdir/$subdir
gdb_load ${binfile}

if ![runto_main] then {
   fail "Can't run to main"
      return 1;
}

#
# set breakpoint at thread fucntion tf
#
gdb_test "break tf" \
    "Breakpoint.*at.* file .*$srcfile, line.*" \
    "breakpoint tf"


#
#
# continue to tf() breakpoint #2
#
send_gdb "continue\n"
gdb_expect {
    -re ".*Breakpoint 2.*tf.* at .*tbug.* .*\r\n$gdb_prompt $" {
        pass "continue to tf";
    }
    -re ".*$gdb_prompt $" {
        fail "continue to tf";
        return 1;
    }
    timeout {
        fail "continue to tf (timeout)";
        return 1;
    }
}

#
# step through the thread function.
#
send_gdb "step\n"
gdb_expect {
    -re "39.*sprintf.* .*\r\n$gdb_prompt $" {
        pass "step to next instruction in tf";
    }
    -re ".*$gdb_prompt $" {
        fail "step to next instruction in tf";
        return 1;
    }
    timeout {
        fail "step to next instruction in tf (timeout)";
        return 1;
    }
}

#
# backtrace from thread function. 
#
send_gdb "backtrace\n"
gdb_expect {
    -re ".*3.* .*0x.* in clone.* from .*libc.*$" {
        pass "backtrace from thread function";
    }
    -re ".*$gdb_prompt $" {
        fail "backtrace from thread function";
        return 1;
    }
    timeout {
        fail "backtrace from thread function (timeout)";
        return 1;
    }
}

#
# delete all breakpoints
#
send_gdb "delete\n"
gdb_expect 100 {         
    -re "Delete all breakpoints.*$" {
        send_gdb "y\n";
        exp_continue
    }
    -re ".*$gdb_prompt $" {
        # no more breakpoints then do nothing
    }
    timeout { 
        perror "Delete all breakpoints in delete_breakpoints (timeout)"; 
        return 0;
    }
}

#
# exit gdb
#
gdb_exit

Re: [RFC] New thread testcase.

[Michael Chastain]

Hi Manoj,

I am not the maintainer of gdb.threads -- that is Michael Snyder.
(See the gdb/MAINTAINERS file for a list of who maintains what
subdirectory).  You'll have to work with Michael Snyder on this
patch.  I can give you some feedback though.

The basic idea of the test is good but it needs revision.  Don't get
discouraged by the long list that follows.  I spent some time
proof-reading this because I think it's good and I want it to get in.

Also, since this is Michael Snyder's area, anything he says
outweighs anything I say.  The changes below are just my advice.

Michael C

===

  tbug.c

    I think this name is too generic.  gdb.threads is full of
    files which are about thread bugs.

  * Please email any bugs, comments, and/or additions to this file to:
  * bug-gdb@prep.ai.mit.edu

    Drop this part, bug-gdb@prep.ai.mit.edu is dead.

  sleep(2);

    See the call to sleep() in gdb.mi/pthreads.c:

      /* When gdb is running, it sets hidden breakpoints in the thread
	 library.  The signals caused by these hidden breakpoints can
	 cause system calls such as 'sleep' to return early.  Pay attention
	 to the return value from 'sleep' to get the full sleep.  */
      int unslept = 9;
      while (unslept > 0)
	unslept = sleep (unslept);

    All the sleep() calls in gdb.threads need to be like this.
    See gdb.texinfo, section "Stopping and starting multi-thread
    programs", for more information on this.

  thread_check.exp

    Same complaint about the name.

  'bracktrace'

    Typo.

  'On ppc64 system this test is known to fail due to kernel bug
   in ptrace system call.'

    This is a start, but more info please.  ppc64 is just a processor,
    we need a whole gnu triple here, like ppc64-unknown-linux-gnu.
    Run 'config.guess' on the system where it fails and report that
    info.  Also run 'uname -a' and get the kernel version.  And it
    would help to report the libc / glibc version as well.

  send_gdb / gdb_expect

    We are moving away from those to gdb_test_multiple.
    With gdb_test_multiple, you don't need the default FAIL case
    and the timeout case.

  send_gdb "delete\n"
  gdb_expect 100 {

    Drop the timeout, you should not need a special timeout
    for deleting breakpoints.

  -re "39.*sprintf.* .*\r\n$gdb_prompt $" {

    Do not use absolute line numbers!  Call gdb_get_line_number to
    get the line number you want.

      set marker_1 [gdb_get_line_number "marker 1"]
      ...
      -re "$marker_1.*sprintf.* .*\r\n$gdb_prompt $" {

    Then in the test program, do this:

      sprintf(number, "tf(%ld): begin", (long)arg); /* marker 1 */

  -re ".*3.* .*0x.* in clone.* from .*libc.*$" {

    This is not generic enough.  There's no guarantee that
    pthread_create is implemented with clone.  For your purposes,
    is it good enough to look for pthread_create on the stack?

Re: [RFC] New thread testcase.

[Andrew Cagney]

> Hi Manoj,
> 
> I am not the maintainer of gdb.threads -- that is Michael Snyder.
> (See the gdb/MAINTAINERS file for a list of who maintains what
> subdirectory).  You'll have to work with Michael Snyder on this
> patch.  I can give you some feedback though.
> 
> The basic idea of the test is good but it needs revision.  Don't get
> discouraged by the long list that follows.  I spent some time
> proof-reading this because I think it's good and I want it to get in.
> 
> Also, since this is Michael Snyder's area, anything he says
> outweighs anything I say.  The changes below are just my advice.

Manoj,

You've got me curious.  Do any of the existing tests exercise this bug 
(manythreads.exp comes to mind)?   Oh, and what is the bug? :-)

Andrew

Re: [RFC] New thread testcase.

[Manoj Iyer]

> Manoj,
>
> You've got me curious.  Do any of the existing tests exercise this bug
> (manythreads.exp comes to mind)?   Oh, and what is the bug? :-)
>

This is a generic kernel bug (in ptrace() )that causes ptrace to fail on
Power 64 systems.  Please look at PR#1712 for details.


Thanks
Manoj Iyer

Re: [RFC] New thread testcase.

[Andrew Cagney]

>>Manoj,
>>>
>>> You've got me curious.  Do any of the existing tests exercise this bug
>>> (manythreads.exp comes to mind)?   Oh, and what is the bug? :-)
>>>
> 
> 
> This is a generic kernel bug (in ptrace() )that causes ptrace to fail on
> Power 64 systems.  Please look at PR#1712 for details.

Unfortunatly 1712 doesn't answer my question.  What is the bug?  What 
causes ptrace to fail?

Andrew

Re: [RFC] New thread testcase.

[Manoj Iyer]

oh! sorry abt that... got confused btwn 'bugs'...

The kernel bug was causing gdb to fail when passing a 32bit address to the
kernel.  this was causing 32 bit gdb to fail in linux_test_for_tracefork()
by always returning second_pid = 0 in the PTRACE_GETEVENTMSG call.

this resulted in linux_enable_event_reporting() not setting the PTRACE
fork options for the pid and then the thread never received a SIGSTOP.

John Engel, kernel developer, debugged and fixed this problem in the
kernel after we reported this GDB problem to him...

So, when you debug a multi-threaded app with 32bit GDB on a PPC64 system,
and you set a break point at the thread function and tried to step, you
get the message "reading register pc (#64): No such process." for example:

Breakpoint 1, main (argc=1, argv=0xffffe464) at tbug.c:31
31        for (n = 0; n < N; ++n)
(gdb) cont
Continuing.
[New Thread 1078217504 (LWP 26708)]
tf(0): begin
[New Thread 1082411808 (LWP 26709)]
after create
tf(1): begin
tf(0): end
[Thread 1078217504 (LWP 26708) exited]
tf(1): end
[Thread 1082411808 (LWP 26709) exited]
after join

Program exited normally.
(gdb) clear main
Deleted breakpoint 1
(gdb) break tf
Breakpoint 2 at 0x10000594: file tbug.c, line 15.
(gdb) run
Starting program: /home/public/test-tools/gdb/tbug
[Thread debugging using libthread_db enabled]
[New Thread 1074020384 (LWP 26710)]
reading register pc (#64): No such process.
(gdb) cont
Continuing.
reading register pc (#64): No such process.

Thanks
----- ----
Manoj Iyer
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ Cognito ergo sum +
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

On Tue, 10 Aug 2004, Andrew Cagney wrote:

> >>Manoj,
> >>>
> >>> You've got me curious.  Do any of the existing tests exercise this bug
> >>> (manythreads.exp comes to mind)?   Oh, and what is the bug? :-)
> >>>
> >
> >
> > This is a generic kernel bug (in ptrace() )that causes ptrace to fail on
> > Power 64 systems.  Please look at PR#1712 for details.
>
> Unfortunatly 1712 doesn't answer my question.  What is the bug?  What
> causes ptrace to fail?
>
> Andrew
>
>
>

Re: [RFC] New thread testcase.

[Andrew Cagney]

> oh! sorry abt that... got confused btwn 'bugs'...
> 
> The kernel bug was causing gdb to fail when passing a 32bit address to the
> kernel.  this was causing 32 bit gdb to fail in linux_test_for_tracefork()
> by always returning second_pid = 0 in the PTRACE_GETEVENTMSG call.
> 
> this resulted in linux_enable_event_reporting() not setting the PTRACE
> fork options for the pid and then the thread never received a SIGSTOP.
> 
> John Engel, kernel developer, debugged and fixed this problem in the
> kernel after we reported this GDB problem to him...
> 
> So, when you debug a multi-threaded app with 32bit GDB on a PPC64 system,
> and you set a break point at the thread function and tried to step, you
> get the message "reading register pc (#64): No such process." for example:

Ewww!  Yes, very good test, should have exercised this [not so] edge 
case years ago.

One tweak, can the sleep(100) be avoided, instead using synchronization 
primatives?  That way its clear that the test runs at full speed.

Andrew

Re: [RFC] New thread testcase.

[Michael Snyder]

Manoj,

It sounds from your eplanation like the "step" part of your test
is not required, since your bug shows up without it.  I explained
in my previous msg why I was concerned about that test.  What
would you think of removing the step?

Michael

Manoj Iyer wrote:
> oh! sorry abt that... got confused btwn 'bugs'...
> 
> The kernel bug was causing gdb to fail when passing a 32bit address to the
> kernel.  this was causing 32 bit gdb to fail in linux_test_for_tracefork()
> by always returning second_pid = 0 in the PTRACE_GETEVENTMSG call.
> 
> this resulted in linux_enable_event_reporting() not setting the PTRACE
> fork options for the pid and then the thread never received a SIGSTOP.
> 
> John Engel, kernel developer, debugged and fixed this problem in the
> kernel after we reported this GDB problem to him...
> 
> So, when you debug a multi-threaded app with 32bit GDB on a PPC64 system,
> and you set a break point at the thread function and tried to step, you
> get the message "reading register pc (#64): No such process." for example:
> 
> Breakpoint 1, main (argc=1, argv=0xffffe464) at tbug.c:31
> 31        for (n = 0; n < N; ++n)
> (gdb) cont
> Continuing.
> [New Thread 1078217504 (LWP 26708)]
> tf(0): begin
> [New Thread 1082411808 (LWP 26709)]
> after create
> tf(1): begin
> tf(0): end
> [Thread 1078217504 (LWP 26708) exited]
> tf(1): end
> [Thread 1082411808 (LWP 26709) exited]
> after join
> 
> Program exited normally.
> (gdb) clear main
> Deleted breakpoint 1
> (gdb) break tf
> Breakpoint 2 at 0x10000594: file tbug.c, line 15.
> (gdb) run
> Starting program: /home/public/test-tools/gdb/tbug
> [Thread debugging using libthread_db enabled]
> [New Thread 1074020384 (LWP 26710)]
> reading register pc (#64): No such process.
> (gdb) cont
> Continuing.
> reading register pc (#64): No such process.
> 
> Thanks
> ----- ----
> Manoj Iyer
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> + Cognito ergo sum +
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 
> On Tue, 10 Aug 2004, Andrew Cagney wrote:
> 
> 
>>>>Manoj,
>>>>
>>>>>You've got me curious.  Do any of the existing tests exercise this bug
>>>>>(manythreads.exp comes to mind)?   Oh, and what is the bug? :-)
>>>>>
>>>
>>>
>>>This is a generic kernel bug (in ptrace() )that causes ptrace to fail on
>>>Power 64 systems.  Please look at PR#1712 for details.
>>
>>Unfortunatly 1712 doesn't answer my question.  What is the bug?  What
>>causes ptrace to fail?
>>
>>Andrew
>>
>>
>>
> 
> 

Re: [RFC] New thread testcase.

[Manoj Iyer]

Yes you are correct, I did note the same I can modify the testcase and
and incorporate other suggestions as well. Will that qualify for
acceptance?

Thanks
-----
manjo
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ Cognito ergo sum                                                          +
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

On Fri, 27 Aug 2004, Michael Snyder wrote:

> Manoj,
>
> It sounds from your eplanation like the "step" part of your test
> is not required, since your bug shows up without it.  I explained
> in my previous msg why I was concerned about that test.  What
> would you think of removing the step?
>
> Michael
>
> Manoj Iyer wrote:
> > oh! sorry abt that... got confused btwn 'bugs'...
> >
> > The kernel bug was causing gdb to fail when passing a 32bit address to the
> > kernel.  this was causing 32 bit gdb to fail in linux_test_for_tracefork()
> > by always returning second_pid = 0 in the PTRACE_GETEVENTMSG call.
> >
> > this resulted in linux_enable_event_reporting() not setting the PTRACE
> > fork options for the pid and then the thread never received a SIGSTOP.
> >
> > John Engel, kernel developer, debugged and fixed this problem in the
> > kernel after we reported this GDB problem to him...
> >
> > So, when you debug a multi-threaded app with 32bit GDB on a PPC64 system,
> > and you set a break point at the thread function and tried to step, you
> > get the message "reading register pc (#64): No such process." for example:
> >
> > Breakpoint 1, main (argc=1, argv=0xffffe464) at tbug.c:31
> > 31        for (n = 0; n < N; ++n)
> > (gdb) cont
> > Continuing.
> > [New Thread 1078217504 (LWP 26708)]
> > tf(0): begin
> > [New Thread 1082411808 (LWP 26709)]
> > after create
> > tf(1): begin
> > tf(0): end
> > [Thread 1078217504 (LWP 26708) exited]
> > tf(1): end
> > [Thread 1082411808 (LWP 26709) exited]
> > after join
> >
> > Program exited normally.
> > (gdb) clear main
> > Deleted breakpoint 1
> > (gdb) break tf
> > Breakpoint 2 at 0x10000594: file tbug.c, line 15.
> > (gdb) run
> > Starting program: /home/public/test-tools/gdb/tbug
> > [Thread debugging using libthread_db enabled]
> > [New Thread 1074020384 (LWP 26710)]
> > reading register pc (#64): No such process.
> > (gdb) cont
> > Continuing.
> > reading register pc (#64): No such process.
> >
> > Thanks
> > ----- ----
> > Manoj Iyer
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > + Cognito ergo sum +
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >
> > On Tue, 10 Aug 2004, Andrew Cagney wrote:
> >
> >
> >>>>Manoj,
> >>>>
> >>>>>You've got me curious.  Do any of the existing tests exercise this bug
> >>>>>(manythreads.exp comes to mind)?   Oh, and what is the bug? :-)
> >>>>>
> >>>
> >>>
> >>>This is a generic kernel bug (in ptrace() )that causes ptrace to fail on
> >>>Power 64 systems.  Please look at PR#1712 for details.
> >>
> >>Unfortunatly 1712 doesn't answer my question.  What is the bug?  What
> >>causes ptrace to fail?
> >>
> >>Andrew
> >>
> >>
> >>
> >
> >
>
>
>

Re: [RFC] New thread testcase.

[Manoj Iyer]

Wow! Michael,

That was really great feedback! A very through review, even typos! I will
fix the testcase with the changes you mentioned and submit again.

Andrew,

yes, manythreads.c and tbug.c look similar, but the tests (*.exp) intend
to test different things. (I believe). My testcase intends to check if we
can set a breakpoint at a thread function, step thro it, backtrace from
it, delete breakpoints and run to completion.

Is there a quick reference list of testcases with Assertion/Strategy ??

Thanks a ton!
----- ----
Manoj Iyer
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ Cognito ergo sum                                                          +
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

On Tue, 10 Aug 2004, Michael Chastain wrote:

> Hi Manoj,
>
> I am not the maintainer of gdb.threads -- that is Michael Snyder.
> (See the gdb/MAINTAINERS file for a list of who maintains what
> subdirectory).  You'll have to work with Michael Snyder on this
> patch.  I can give you some feedback though.
>
> The basic idea of the test is good but it needs revision.  Don't get
> discouraged by the long list that follows.  I spent some time
> proof-reading this because I think it's good and I want it to get in.
>
> Also, since this is Michael Snyder's area, anything he says
> outweighs anything I say.  The changes below are just my advice.
>
> Michael C
>
> ===
>
>   tbug.c
>
>     I think this name is too generic.  gdb.threads is full of
>     files which are about thread bugs.
>
>   * Please email any bugs, comments, and/or additions to this file to:
>   * bug-gdb@prep.ai.mit.edu
>
>     Drop this part, bug-gdb@prep.ai.mit.edu is dead.
>
>   sleep(2);
>
>     See the call to sleep() in gdb.mi/pthreads.c:
>
>       /* When gdb is running, it sets hidden breakpoints in the thread
> 	 library.  The signals caused by these hidden breakpoints can
> 	 cause system calls such as 'sleep' to return early.  Pay attention
> 	 to the return value from 'sleep' to get the full sleep.  */
>       int unslept = 9;
>       while (unslept > 0)
> 	unslept = sleep (unslept);
>
>     All the sleep() calls in gdb.threads need to be like this.
>     See gdb.texinfo, section "Stopping and starting multi-thread
>     programs", for more information on this.
>
>   thread_check.exp
>
>     Same complaint about the name.
>
>   'bracktrace'
>
>     Typo.
>
>   'On ppc64 system this test is known to fail due to kernel bug
>    in ptrace system call.'
>
>     This is a start, but more info please.  ppc64 is just a processor,
>     we need a whole gnu triple here, like ppc64-unknown-linux-gnu.
>     Run 'config.guess' on the system where it fails and report that
>     info.  Also run 'uname -a' and get the kernel version.  And it
>     would help to report the libc / glibc version as well.
>
>   send_gdb / gdb_expect
>
>     We are moving away from those to gdb_test_multiple.
>     With gdb_test_multiple, you don't need the default FAIL case
>     and the timeout case.
>
>   send_gdb "delete\n"
>   gdb_expect 100 {
>
>     Drop the timeout, you should not need a special timeout
>     for deleting breakpoints.
>
>   -re "39.*sprintf.* .*\r\n$gdb_prompt $" {
>
>     Do not use absolute line numbers!  Call gdb_get_line_number to
>     get the line number you want.
>
>       set marker_1 [gdb_get_line_number "marker 1"]
>       ...
>       -re "$marker_1.*sprintf.* .*\r\n$gdb_prompt $" {
>
>     Then in the test program, do this:
>
>       sprintf(number, "tf(%ld): begin", (long)arg); /* marker 1 */
>
>   -re ".*3.* .*0x.* in clone.* from .*libc.*$" {
>
>     This is not generic enough.  There's no guarantee that
>     pthread_create is implemented with clone.  For your purposes,
>     is it good enough to look for pthread_create on the stack?
>

Re: [RFC] New thread testcase.

[Michael Snyder]

Hello Manoj,

> #
> # step through the thread function.
> #
> send_gdb "step\n"
> gdb_expect {
>     -re "39.*sprintf.* .*\r\n$gdb_prompt $" {
>         pass "step to next instruction in tf";
>     }
>     -re ".*$gdb_prompt $" {
>         fail "step to next instruction in tf";
>         return 1;
>     }
>     timeout {
>         fail "step to next instruction in tf (timeout)";
>         return 1;
>     }
> }

This will probably work as written, but it hints at a faulty
assumption that might lead it to break if the test is modified
in the future.

When you say "step", you allow the opportunity for the inferior
to switch thread contexts.  At present there are only two threads,
and no other breakpoints exist that might be hit, but if that were
not the case, the next stop event could be at another breakpoint,
in another thread.  This would not be a bug, and should not cause
a fail.  It's expected behavior.

I suppose this could be addressed with a comment, warning the
future maintainer to take it into consideration if more threads
or breakpoints are added.

But like Andrew, I would also like to know what the expected
failure is -- what used to happen before the kernel bug was
fixed?  A comment explaining that would be welcome too.

Michael Snyder