[RFA] Fix typos in gdb_compile_pthreads

[RFA] Fix typos in gdb_compile_pthreads

[Keith Seitz]

Hi,

This simple patch fixes two little typos in gdb_compile_pthreads. One of 
them is simply a typo which causes a tcl error when the code is run and 
the proc is unable to build a binary.

The other doesn't cause any errors, but it wastes cpu time doing a string 
comparison instead of simple integer comparison.

Keith

ChangeLog
2002-09-03  Keith Seitz  <keiths@redhat.com>

        * lib/gdb.exp (gdb_compile_pthreads): Fix "build_bin" typo.
        Use integer comparison instead of string comparison for testing
        whether binary was built.

Patch
Index: testsuite/lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.24
diff -p -r1.24 gdb.exp
*** testsuite/lib/gdb.exp	29 Aug 2002 22:36:52 -0000	1.24
--- testsuite/lib/gdb.exp	3 Sep 2002 18:51:29 -0000
*************** proc gdb_compile {source dest type optio
*** 1176,1182 ****
  # against several different thread libraries, to see which one this
  # system has.
  proc gdb_compile_pthreads {source dest type options} {
!     set build_binfile 0
      set why_msg "unrecognized error"
      foreach lib {-lpthreads -lpthread -lthread} {
          # This kind of wipes out whatever libs the caller may have
--- 1176,1182 ----
  # against several different thread libraries, to see which one this
  # system has.
  proc gdb_compile_pthreads {source dest type options} {
!     set built_binfile 0
      set why_msg "unrecognized error"
      foreach lib {-lpthreads -lpthread -lthread} {
          # This kind of wipes out whatever libs the caller may have
*************** proc gdb_compile_pthreads {source dest t
*** 1201,1207 ****
              }
          }
      }
!     if {$built_binfile == "0"} {
          unsupported "Couldn't compile $source: ${why_msg}"
          return -1
      }
--- 1201,1207 ----
              }
          }
      }
!     if {!$built_binfile} {
          unsupported "Couldn't compile $source: ${why_msg}"
          return -1
      }

Re: [RFA] Fix typos in gdb_compile_pthreads

[Andrew Cagney]

> Hi,
> 
> This simple patch fixes two little typos in gdb_compile_pthreads. One of 
> them is simply a typo which causes a tcl error when the code is run and 
> the proc is unable to build a binary.
> 
> The other doesn't cause any errors, but it wastes cpu time doing a string 
> comparison instead of simple integer comparison.
> 
> Keith
> 
> ChangeLog
> 2002-09-03  Keith Seitz  <keiths@redhat.com>
> 
>         * lib/gdb.exp (gdb_compile_pthreads): Fix "build_bin" typo.
>         Use integer comparison instead of string comparison for testing
>         whether binary was built.

Given you know more than most about tcl, I suspect to you these are 
obvious :-)

I'd say, yes, ok.  You have <2 hours to commit this :-)

Andrew


> Patch
> Index: testsuite/lib/gdb.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
> retrieving revision 1.24
> diff -p -r1.24 gdb.exp
> *** testsuite/lib/gdb.exp	29 Aug 2002 22:36:52 -0000	1.24
> --- testsuite/lib/gdb.exp	3 Sep 2002 18:51:29 -0000
> *************** proc gdb_compile {source dest type optio
> *** 1176,1182 ****
>   # against several different thread libraries, to see which one this
>   # system has.
>   proc gdb_compile_pthreads {source dest type options} {
> !     set build_binfile 0
>       set why_msg "unrecognized error"
>       foreach lib {-lpthreads -lpthread -lthread} {
>           # This kind of wipes out whatever libs the caller may have
> --- 1176,1182 ----
>   # against several different thread libraries, to see which one this
>   # system has.
>   proc gdb_compile_pthreads {source dest type options} {
> !     set built_binfile 0
>       set why_msg "unrecognized error"
>       foreach lib {-lpthreads -lpthread -lthread} {
>           # This kind of wipes out whatever libs the caller may have
> *************** proc gdb_compile_pthreads {source dest t
> *** 1201,1207 ****
>               }
>           }
>       }
> !     if {$built_binfile == "0"} {
>           unsupported "Couldn't compile $source: ${why_msg}"
>           return -1
>       }
> --- 1201,1207 ----
>               }
>           }
>       }
> !     if {!$built_binfile} {
>           unsupported "Couldn't compile $source: ${why_msg}"
>           return -1
>       }
> 
> 

Re: [RFA] Fix typos in gdb_compile_pthreads

[Keith Seitz]

On Tue, 3 Sep 2002, Andrew Cagney wrote:

> Given you know more than most about tcl, I suspect to you these are 
> obvious :-)
> 
> I'd say, yes, ok.  You have <2 hours to commit this :-)

Doh! You're right -- they are pretty obvious (well, the typo, at least).

Committed.

Thanks,
Keith