Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] Fix typos in gdb_compile_pthreads
Date: Tue, 03 Sep 2002 11:53:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.44.0209031154230.1397-100000@valrhona.uglyboxes.com> (raw)

Hi,

This simple patch fixes two little typos in gdb_compile_pthreads. One of 
them is simply a typo which causes a tcl error when the code is run and 
the proc is unable to build a binary.

The other doesn't cause any errors, but it wastes cpu time doing a string 
comparison instead of simple integer comparison.

Keith

ChangeLog
2002-09-03  Keith Seitz  <keiths@redhat.com>

        * lib/gdb.exp (gdb_compile_pthreads): Fix "build_bin" typo.
        Use integer comparison instead of string comparison for testing
        whether binary was built.

Patch
Index: testsuite/lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.24
diff -p -r1.24 gdb.exp
*** testsuite/lib/gdb.exp	29 Aug 2002 22:36:52 -0000	1.24
--- testsuite/lib/gdb.exp	3 Sep 2002 18:51:29 -0000
*************** proc gdb_compile {source dest type optio
*** 1176,1182 ****
  # against several different thread libraries, to see which one this
  # system has.
  proc gdb_compile_pthreads {source dest type options} {
!     set build_binfile 0
      set why_msg "unrecognized error"
      foreach lib {-lpthreads -lpthread -lthread} {
          # This kind of wipes out whatever libs the caller may have
--- 1176,1182 ----
  # against several different thread libraries, to see which one this
  # system has.
  proc gdb_compile_pthreads {source dest type options} {
!     set built_binfile 0
      set why_msg "unrecognized error"
      foreach lib {-lpthreads -lpthread -lthread} {
          # This kind of wipes out whatever libs the caller may have
*************** proc gdb_compile_pthreads {source dest t
*** 1201,1207 ****
              }
          }
      }
!     if {$built_binfile == "0"} {
          unsupported "Couldn't compile $source: ${why_msg}"
          return -1
      }
--- 1201,1207 ----
              }
          }
      }
!     if {!$built_binfile} {
          unsupported "Couldn't compile $source: ${why_msg}"
          return -1
      }


             reply	other threads:[~2002-09-03 18:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-03 11:53 Keith Seitz [this message]
2002-09-03 15:06 ` Andrew Cagney
2002-09-03 15:29   ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0209031154230.1397-100000@valrhona.uglyboxes.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox