From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-18363-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 9856 invoked by alias); 3 Sep 2002 18:53:55 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 9798 invoked from network); 3 Sep 2002 18:53:53 -0000
Received: from unknown (HELO valrhona.uglyboxes.com) (64.1.192.220)
  by sources.redhat.com with SMTP; 3 Sep 2002 18:53:53 -0000
Received: from localhost.localdomain (IDENT:awWdBO0Usj/AbHRtvnBhGby1zxevufMW@localhost.localdomain [127.0.0.1])
	by valrhona.uglyboxes.com (8.11.6/8.11.6) with ESMTP id g83IubG08229
	for <gdb-patches@sources.redhat.com>; Tue, 3 Sep 2002 11:56:38 -0700
Date: Tue, 03 Sep 2002 11:53:00 -0000
From: Keith Seitz <keiths@redhat.com>
X-X-Sender: keiths@valrhona.uglyboxes.com
To: gdb-patches@sources.redhat.com
Subject: [RFA] Fix typos in gdb_compile_pthreads
Message-ID: <Pine.LNX.4.44.0209031154230.1397-100000@valrhona.uglyboxes.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-09/txt/msg00037.txt.bz2

Hi,

This simple patch fixes two little typos in gdb_compile_pthreads. One of 
them is simply a typo which causes a tcl error when the code is run and 
the proc is unable to build a binary.

The other doesn't cause any errors, but it wastes cpu time doing a string 
comparison instead of simple integer comparison.

Keith

ChangeLog
2002-09-03  Keith Seitz  <keiths@redhat.com>

        * lib/gdb.exp (gdb_compile_pthreads): Fix "build_bin" typo.
        Use integer comparison instead of string comparison for testing
        whether binary was built.

Patch
Index: testsuite/lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.24
diff -p -r1.24 gdb.exp
*** testsuite/lib/gdb.exp	29 Aug 2002 22:36:52 -0000	1.24
--- testsuite/lib/gdb.exp	3 Sep 2002 18:51:29 -0000
*************** proc gdb_compile {source dest type optio
*** 1176,1182 ****
  # against several different thread libraries, to see which one this
  # system has.
  proc gdb_compile_pthreads {source dest type options} {
!     set build_binfile 0
      set why_msg "unrecognized error"
      foreach lib {-lpthreads -lpthread -lthread} {
          # This kind of wipes out whatever libs the caller may have
--- 1176,1182 ----
  # against several different thread libraries, to see which one this
  # system has.
  proc gdb_compile_pthreads {source dest type options} {
!     set built_binfile 0
      set why_msg "unrecognized error"
      foreach lib {-lpthreads -lpthread -lthread} {
          # This kind of wipes out whatever libs the caller may have
*************** proc gdb_compile_pthreads {source dest t
*** 1201,1207 ****
              }
          }
      }
!     if {$built_binfile == "0"} {
          unsupported "Couldn't compile $source: ${why_msg}"
          return -1
      }
--- 1201,1207 ----
              }
          }
      }
!     if {!$built_binfile} {
          unsupported "Couldn't compile $source: ${why_msg}"
          return -1
      }