* [RFA] stabsread and const/volatile vars
@ 2001-08-01 22:24 Don Howard
2001-08-02 10:43 ` Jim Blandy
2001-08-02 21:14 ` Jim Blandy
0 siblings, 2 replies; 5+ messages in thread
From: Don Howard @ 2001-08-01 22:24 UTC (permalink / raw)
To: gdb-patches
[Credit to Jim Blandy for walking me through this.]
2001-08-01 Don Howard <dhoward@redhat.com>
* stabsread.c (read_type): Add support for const and volatile
modifiers.
Index: stabsread.c
===================================================================
RCS file: /cvs/src/src/gdb/stabsread.c,v
retrieving revision 1.14
diff -p -u -w -r1.14 stabsread.c
--- stabsread.c 2001/08/01 18:39:23 1.14
+++ stabsread.c 2001/08/02 05:18:40
@@ -2586,7 +2586,7 @@ again:
if (type_descriptor == 'c' && !os9k_stabs)
return error_type (pp, objfile);
type = read_type (pp, objfile);
- /* FIXME! For now, we ignore const and volatile qualifiers. */
+ type = make_cv_type (1, TYPE_VOLATILE (type), type, 0);
break;
case 'B': /* Volatile qual on some type (Sun) */
@@ -2596,7 +2596,7 @@ again:
if (type_descriptor == 'i' && !os9k_stabs)
return error_type (pp, objfile);
type = read_type (pp, objfile);
- /* FIXME! For now, we ignore const and volatile qualifiers. */
+ type = make_cv_type (TYPE_CONST (type), 1, type, 0);
break;
case '@':
--
-Don
dhoward@redhat.com
gdb engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] stabsread and const/volatile vars
2001-08-01 22:24 [RFA] stabsread and const/volatile vars Don Howard
@ 2001-08-02 10:43 ` Jim Blandy
2001-08-02 21:14 ` Jim Blandy
1 sibling, 0 replies; 5+ messages in thread
From: Jim Blandy @ 2001-08-02 10:43 UTC (permalink / raw)
To: Don Howard; +Cc: gdb-patches
You tried this out on the test suite, right? Did you get a bunch of
new xpasses?
Don Howard <dhoward@redhat.com> writes:
>
>
> [Credit to Jim Blandy for walking me through this.]
>
> 2001-08-01 Don Howard <dhoward@redhat.com>
>
> * stabsread.c (read_type): Add support for const and volatile
> modifiers.
>
>
>
> Index: stabsread.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/stabsread.c,v
> retrieving revision 1.14
> diff -p -u -w -r1.14 stabsread.c
> --- stabsread.c 2001/08/01 18:39:23 1.14
> +++ stabsread.c 2001/08/02 05:18:40
> @@ -2586,7 +2586,7 @@ again:
> if (type_descriptor == 'c' && !os9k_stabs)
> return error_type (pp, objfile);
> type = read_type (pp, objfile);
> - /* FIXME! For now, we ignore const and volatile qualifiers. */
> + type = make_cv_type (1, TYPE_VOLATILE (type), type, 0);
> break;
>
> case 'B': /* Volatile qual on some type (Sun) */
> @@ -2596,7 +2596,7 @@ again:
> if (type_descriptor == 'i' && !os9k_stabs)
> return error_type (pp, objfile);
> type = read_type (pp, objfile);
> - /* FIXME! For now, we ignore const and volatile qualifiers. */
> + type = make_cv_type (TYPE_CONST (type), 1, type, 0);
> break;
>
> case '@':
>
>
> --
> -Don
> dhoward@redhat.com
> gdb engineering
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] stabsread and const/volatile vars
2001-08-01 22:24 [RFA] stabsread and const/volatile vars Don Howard
2001-08-02 10:43 ` Jim Blandy
@ 2001-08-02 21:14 ` Jim Blandy
2001-08-07 15:38 ` Don Howard
1 sibling, 1 reply; 5+ messages in thread
From: Jim Blandy @ 2001-08-02 21:14 UTC (permalink / raw)
To: Don Howard; +Cc: gdb-patches
As Elena pointed out in private E-mail, since GCC doesn't emit the
const and volatile stabs, this change won't have any effect. However,
since the GCC folks often claim that they haven't enhanced GCC to emit
a particular kind of debug info because GDB wouldn't consume it, I
think this change is a good one --- it removes an excuse. :)
Don Howard <dhoward@redhat.com> writes:
>
>
> [Credit to Jim Blandy for walking me through this.]
>
> 2001-08-01 Don Howard <dhoward@redhat.com>
>
> * stabsread.c (read_type): Add support for const and volatile
> modifiers.
>
>
>
> Index: stabsread.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/stabsread.c,v
> retrieving revision 1.14
> diff -p -u -w -r1.14 stabsread.c
> --- stabsread.c 2001/08/01 18:39:23 1.14
> +++ stabsread.c 2001/08/02 05:18:40
> @@ -2586,7 +2586,7 @@ again:
> if (type_descriptor == 'c' && !os9k_stabs)
> return error_type (pp, objfile);
> type = read_type (pp, objfile);
> - /* FIXME! For now, we ignore const and volatile qualifiers. */
> + type = make_cv_type (1, TYPE_VOLATILE (type), type, 0);
> break;
>
> case 'B': /* Volatile qual on some type (Sun) */
> @@ -2596,7 +2596,7 @@ again:
> if (type_descriptor == 'i' && !os9k_stabs)
> return error_type (pp, objfile);
> type = read_type (pp, objfile);
> - /* FIXME! For now, we ignore const and volatile qualifiers. */
> + type = make_cv_type (TYPE_CONST (type), 1, type, 0);
> break;
>
> case '@':
>
>
> --
> -Don
> dhoward@redhat.com
> gdb engineering
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] stabsread and const/volatile vars
2001-08-02 21:14 ` Jim Blandy
@ 2001-08-07 15:38 ` Don Howard
2001-08-07 16:30 ` Jim Blandy
0 siblings, 1 reply; 5+ messages in thread
From: Don Howard @ 2001-08-07 15:38 UTC (permalink / raw)
To: Jim Blandy; +Cc: gdb-patches
Ok to commit, then?
On 2 Aug 2001, Jim Blandy wrote:
>
> As Elena pointed out in private E-mail, since GCC doesn't emit the
> const and volatile stabs, this change won't have any effect. However,
> since the GCC folks often claim that they haven't enhanced GCC to emit
> a particular kind of debug info because GDB wouldn't consume it, I
> think this change is a good one --- it removes an excuse. :)
>
>
> Don Howard <dhoward@redhat.com> writes:
>
> >
> >
> > [Credit to Jim Blandy for walking me through this.]
> >
> > 2001-08-01 Don Howard <dhoward@redhat.com>
> >
> > * stabsread.c (read_type): Add support for const and volatile
> > modifiers.
> >
> >
> >
> > Index: stabsread.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/stabsread.c,v
> > retrieving revision 1.14
> > diff -p -u -w -r1.14 stabsread.c
> > --- stabsread.c 2001/08/01 18:39:23 1.14
> > +++ stabsread.c 2001/08/02 05:18:40
> > @@ -2586,7 +2586,7 @@ again:
> > if (type_descriptor == 'c' && !os9k_stabs)
> > return error_type (pp, objfile);
> > type = read_type (pp, objfile);
> > - /* FIXME! For now, we ignore const and volatile qualifiers. */
> > + type = make_cv_type (1, TYPE_VOLATILE (type), type, 0);
> > break;
> >
> > case 'B': /* Volatile qual on some type (Sun) */
> > @@ -2596,7 +2596,7 @@ again:
> > if (type_descriptor == 'i' && !os9k_stabs)
> > return error_type (pp, objfile);
> > type = read_type (pp, objfile);
> > - /* FIXME! For now, we ignore const and volatile qualifiers. */
> > + type = make_cv_type (TYPE_CONST (type), 1, type, 0);
> > break;
> >
> > case '@':
> >
> >
> > --
> > -Don
> > dhoward@redhat.com
> > gdb engineering
> >
> >
> >
>
--
-Don
dhoward@redhat.com
gdb engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] stabsread and const/volatile vars
2001-08-07 15:38 ` Don Howard
@ 2001-08-07 16:30 ` Jim Blandy
0 siblings, 0 replies; 5+ messages in thread
From: Jim Blandy @ 2001-08-07 16:30 UTC (permalink / raw)
To: Don Howard; +Cc: gdb-patches
Yes.
Don Howard <dhoward@redhat.com> writes:
>
>
>
> Ok to commit, then?
>
>
> On 2 Aug 2001, Jim Blandy wrote:
>
> >
> > As Elena pointed out in private E-mail, since GCC doesn't emit the
> > const and volatile stabs, this change won't have any effect. However,
> > since the GCC folks often claim that they haven't enhanced GCC to emit
> > a particular kind of debug info because GDB wouldn't consume it, I
> > think this change is a good one --- it removes an excuse. :)
> >
> >
> > Don Howard <dhoward@redhat.com> writes:
> >
> > >
> > >
> > > [Credit to Jim Blandy for walking me through this.]
> > >
> > > 2001-08-01 Don Howard <dhoward@redhat.com>
> > >
> > > * stabsread.c (read_type): Add support for const and volatile
> > > modifiers.
> > >
> > >
> > >
> > > Index: stabsread.c
> > > ===================================================================
> > > RCS file: /cvs/src/src/gdb/stabsread.c,v
> > > retrieving revision 1.14
> > > diff -p -u -w -r1.14 stabsread.c
> > > --- stabsread.c 2001/08/01 18:39:23 1.14
> > > +++ stabsread.c 2001/08/02 05:18:40
> > > @@ -2586,7 +2586,7 @@ again:
> > > if (type_descriptor == 'c' && !os9k_stabs)
> > > return error_type (pp, objfile);
> > > type = read_type (pp, objfile);
> > > - /* FIXME! For now, we ignore const and volatile qualifiers. */
> > > + type = make_cv_type (1, TYPE_VOLATILE (type), type, 0);
> > > break;
> > >
> > > case 'B': /* Volatile qual on some type (Sun) */
> > > @@ -2596,7 +2596,7 @@ again:
> > > if (type_descriptor == 'i' && !os9k_stabs)
> > > return error_type (pp, objfile);
> > > type = read_type (pp, objfile);
> > > - /* FIXME! For now, we ignore const and volatile qualifiers. */
> > > + type = make_cv_type (TYPE_CONST (type), 1, type, 0);
> > > break;
> > >
> > > case '@':
> > >
> > >
> > > --
> > > -Don
> > > dhoward@redhat.com
> > > gdb engineering
> > >
> > >
> > >
> >
>
> --
> -Don
> dhoward@redhat.com
> gdb engineering
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2001-08-07 16:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-01 22:24 [RFA] stabsread and const/volatile vars Don Howard
2001-08-02 10:43 ` Jim Blandy
2001-08-02 21:14 ` Jim Blandy
2001-08-07 15:38 ` Don Howard
2001-08-07 16:30 ` Jim Blandy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox