From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Blandy <jimb@zwingli.cygnus.com>
To: Don Howard <dhoward@redhat.com>
Cc: <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] stabsread and const/volatile vars
Date: Tue, 07 Aug 2001 16:30:00 -0000
Message-id: <npsnf3zbun.fsf@zwingli.cygnus.com>
References: <Pine.LNX.4.33.0108071539470.1997-100000@theotherone>
X-SW-Source: 2001-08/msg00071.html

Yes.

Don Howard <dhoward@redhat.com> writes:

> 
> 
> 
> Ok to commit, then?
> 
> 
> On 2 Aug 2001, Jim Blandy wrote:
> 
> >
> > As Elena pointed out in private E-mail, since GCC doesn't emit the
> > const and volatile stabs, this change won't have any effect.  However,
> > since the GCC folks often claim that they haven't enhanced GCC to emit
> > a particular kind of debug info because GDB wouldn't consume it, I
> > think this change is a good one --- it removes an excuse.  :)
> >
> >
> > Don Howard <dhoward@redhat.com> writes:
> >
> > >
> > >
> > > [Credit to Jim Blandy for walking me through this.]
> > >
> > > 2001-08-01  Don Howard  <dhoward@redhat.com>
> > >
> > > 	* stabsread.c (read_type): Add support for const and volatile
> > > 	modifiers.
> > >
> > >
> > >
> > > Index: stabsread.c
> > > ===================================================================
> > > RCS file: /cvs/src/src/gdb/stabsread.c,v
> > > retrieving revision 1.14
> > > diff -p -u -w -r1.14 stabsread.c
> > > --- stabsread.c 2001/08/01 18:39:23     1.14
> > > +++ stabsread.c 2001/08/02 05:18:40
> > > @@ -2586,7 +2586,7 @@ again:
> > >        if (type_descriptor == 'c' && !os9k_stabs)
> > >         return error_type (pp, objfile);
> > >        type = read_type (pp, objfile);
> > > -      /* FIXME! For now, we ignore const and volatile qualifiers.  */
> > > +      type = make_cv_type (1, TYPE_VOLATILE (type), type, 0);
> > >        break;
> > >
> > >      case 'B':                  /* Volatile qual on some type (Sun) */
> > > @@ -2596,7 +2596,7 @@ again:
> > >        if (type_descriptor == 'i' && !os9k_stabs)
> > >         return error_type (pp, objfile);
> > >        type = read_type (pp, objfile);
> > > -      /* FIXME! For now, we ignore const and volatile qualifiers.  */
> > > +      type = make_cv_type (TYPE_CONST (type), 1, type, 0);
> > >        break;
> > >
> > >      case '@':
> > >
> > >
> > > --
> > > -Don
> > > dhoward@redhat.com
> > > gdb engineering
> > >
> > >
> > >
> >
> 
> -- 
> -Don
> dhoward@redhat.com
> gdb engineering
> 
>