Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Don Howard <dhoward@redhat.com>
To: Jim Blandy <jimb@cygnus.com>
Cc: <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] stabsread and const/volatile vars
Date: Tue, 07 Aug 2001 15:38:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.33.0108071539470.1997-100000@theotherone> (raw)
In-Reply-To: <npn15h4w4w.fsf@zwingli.cygnus.com>

Ok to commit, then?


On 2 Aug 2001, Jim Blandy wrote:

>
> As Elena pointed out in private E-mail, since GCC doesn't emit the
> const and volatile stabs, this change won't have any effect.  However,
> since the GCC folks often claim that they haven't enhanced GCC to emit
> a particular kind of debug info because GDB wouldn't consume it, I
> think this change is a good one --- it removes an excuse.  :)
>
>
> Don Howard <dhoward@redhat.com> writes:
>
> >
> >
> > [Credit to Jim Blandy for walking me through this.]
> >
> > 2001-08-01  Don Howard  <dhoward@redhat.com>
> >
> > 	* stabsread.c (read_type): Add support for const and volatile
> > 	modifiers.
> >
> >
> >
> > Index: stabsread.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/stabsread.c,v
> > retrieving revision 1.14
> > diff -p -u -w -r1.14 stabsread.c
> > --- stabsread.c 2001/08/01 18:39:23     1.14
> > +++ stabsread.c 2001/08/02 05:18:40
> > @@ -2586,7 +2586,7 @@ again:
> >        if (type_descriptor == 'c' && !os9k_stabs)
> >         return error_type (pp, objfile);
> >        type = read_type (pp, objfile);
> > -      /* FIXME! For now, we ignore const and volatile qualifiers.  */
> > +      type = make_cv_type (1, TYPE_VOLATILE (type), type, 0);
> >        break;
> >
> >      case 'B':                  /* Volatile qual on some type (Sun) */
> > @@ -2596,7 +2596,7 @@ again:
> >        if (type_descriptor == 'i' && !os9k_stabs)
> >         return error_type (pp, objfile);
> >        type = read_type (pp, objfile);
> > -      /* FIXME! For now, we ignore const and volatile qualifiers.  */
> > +      type = make_cv_type (TYPE_CONST (type), 1, type, 0);
> >        break;
> >
> >      case '@':
> >
> >
> > --
> > -Don
> > dhoward@redhat.com
> > gdb engineering
> >
> >
> >
>

-- 
-Don
dhoward@redhat.com
gdb engineering


  reply	other threads:[~2001-08-07 15:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-01 22:24 Don Howard
2001-08-02 10:43 ` Jim Blandy
2001-08-02 21:14 ` Jim Blandy
2001-08-07 15:38   ` Don Howard [this message]
2001-08-07 16:30     ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.33.0108071539470.1997-100000@theotherone \
    --to=dhoward@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox