[PATCH] gdb: Remove redundant clear_proceed_status() call

[PATCH] gdb: Remove redundant clear_proceed_status() call

[Claudiu Zissulescu]

Remove redundant clear_proceed_status() call. The
init_wait_for_inferior(), which runs on the very next line, already
calls clear_proceed_status (0, false).

Signed-off-by: Claudiu Zissulescu <claudiu.zissulescu-ianculescu@amd.com>
---
 gdb/windows-nat.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index d9e924f16c6..f1660a02175 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -1944,7 +1944,6 @@ windows_nat_target::do_initial_windows_stuff (DWORD pid, bool attaching)
   if (!inf->target_is_pushed (this))
     inf->push_target (this);
   windows_clear_solib ();
-  clear_proceed_status (0);
   init_wait_for_inferior ();
 
   inferior_appeared (inf, pid);
-- 
2.54.0

Re: [PATCH] gdb: Remove redundant clear_proceed_status() call

[Simon Marchi]

On 6/16/26 10:55 AM, Claudiu Zissulescu wrote:
> Remove redundant clear_proceed_status() call. The
> init_wait_for_inferior(), which runs on the very next line, already
> calls clear_proceed_status (0, false).
> 
> Signed-off-by: Claudiu Zissulescu <claudiu.zissulescu-ianculescu@amd.com>
> ---
>  gdb/windows-nat.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
> index d9e924f16c6..f1660a02175 100644
> --- a/gdb/windows-nat.c
> +++ b/gdb/windows-nat.c
> @@ -1944,7 +1944,6 @@ windows_nat_target::do_initial_windows_stuff (DWORD pid, bool attaching)
>    if (!inf->target_is_pushed (this))
>      inf->push_target (this);
>    windows_clear_solib ();
> -  clear_proceed_status (0);
>    init_wait_for_inferior ();
>  
>    inferior_appeared (inf, pid);
> -- 
> 2.54.0
> 

Seems fine to me.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon

Re: [PATCH] gdb: Remove redundant clear_proceed_status() call

[Pedro Alves]

On 2026-06-16 15:55, Claudiu Zissulescu wrote:
> Remove redundant clear_proceed_status() call. The
> init_wait_for_inferior(), which runs on the very next line, already
> calls clear_proceed_status (0, false).

That call passes false, while this one did not.  We know this actually fixes a bug in MI.  Can you
please update the commit log to describe that fix?  A testcase would also be great.  As far as
I know, it wouldn't be complicated -- just a small test using -target-attach.

Pedro Alves

RE: [PATCH] gdb: Remove redundant clear_proceed_status() call

[Zissulescu-Ianculescu, Claudiu]

AMD General

Hi,

I'll respin the patch with Pedro's input.

Thank you,
Claudiu

-----Original Message-----
From: Pedro Alves <pedro@palves.net>
Sent: Tuesday, June 16, 2026 9:02 PM
To: Zissulescu-Ianculescu, Claudiu <Claudiu.Zissulescu-Ianculescu@amd.com>; gdb-patches@sourceware.org
Cc: Six, Lancelot <Lancelot.Six@amd.com>
Subject: Re: [PATCH] gdb: Remove redundant clear_proceed_status() call

[You don't often get email from pedro@palves.net. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


On 2026-06-16 15:55, Claudiu Zissulescu wrote:
> Remove redundant clear_proceed_status() call. The
> init_wait_for_inferior(), which runs on the very next line, already
> calls clear_proceed_status (0, false).

That call passes false, while this one did not.  We know this actually fixes a bug in MI.  Can you please update the commit log to describe that fix?  A testcase would also be great.  As far as I know, it wouldn't be complicated -- just a small test using -target-attach.

Pedro Alves