From: Simon Marchi <simark@simark.ca>
To: Claudiu Zissulescu <claudiu.zissulescu-ianculescu@amd.com>,
gdb-patches@sourceware.org
Cc: pedro@palves.net, lancesix@amd.com
Subject: Re: [PATCH] gdb: Remove redundant clear_proceed_status() call
Date: Tue, 16 Jun 2026 11:49:34 -0400 [thread overview]
Message-ID: <31b3b725-47fa-481b-b7da-27861de34ba1@simark.ca> (raw)
In-Reply-To: <20260616145522.4488-1-claudiu.zissulescu-ianculescu@amd.com>
On 6/16/26 10:55 AM, Claudiu Zissulescu wrote:
> Remove redundant clear_proceed_status() call. The
> init_wait_for_inferior(), which runs on the very next line, already
> calls clear_proceed_status (0, false).
>
> Signed-off-by: Claudiu Zissulescu <claudiu.zissulescu-ianculescu@amd.com>
> ---
> gdb/windows-nat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
> index d9e924f16c6..f1660a02175 100644
> --- a/gdb/windows-nat.c
> +++ b/gdb/windows-nat.c
> @@ -1944,7 +1944,6 @@ windows_nat_target::do_initial_windows_stuff (DWORD pid, bool attaching)
> if (!inf->target_is_pushed (this))
> inf->push_target (this);
> windows_clear_solib ();
> - clear_proceed_status (0);
> init_wait_for_inferior ();
>
> inferior_appeared (inf, pid);
> --
> 2.54.0
>
Seems fine to me.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2026-06-16 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 14:55 Claudiu Zissulescu
2026-06-16 15:49 ` Simon Marchi [this message]
2026-06-16 18:01 ` Pedro Alves
2026-06-17 12:44 ` Zissulescu-Ianculescu, Claudiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31b3b725-47fa-481b-b7da-27861de34ba1@simark.ca \
--to=simark@simark.ca \
--cc=claudiu.zissulescu-ianculescu@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=lancesix@amd.com \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox