From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dsRDJqhwMWpFeAoAWB0awg (envelope-from ) for ; Tue, 16 Jun 2026 11:50:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1781625000; bh=21vYIL74mxpeNx4u6NItwmUerqH9jsPGBvmbegFGWyQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DIj2W+qjIeQEoU+VSO45N3YaU/jXVQAKKLDR3/t9SrSzy3MuBNQDEF3RIUik9ibaP TLBe7OIMUaChwbDYF75E4cHurdyZ99NdmIa5h9+XIY9WTadKMUnXxwN4JmBBj2yB/G FsBy7g6tOb4RsRC7NKes38Bug6qdGP3sgMwcOhjY= Received: by simark.ca (Postfix, from userid 112) id 896931E070; Tue, 16 Jun 2026 11:50:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=OgUzxIdt; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 278F61E070 for ; Tue, 16 Jun 2026 11:50:00 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CDEB948F66BF for ; Tue, 16 Jun 2026 15:49:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CDEB948F66BF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=OgUzxIdt Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 651B048FBCA5 for ; Tue, 16 Jun 2026 15:49:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 651B048FBCA5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 651B048FBCA5 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781624976; cv=none; b=LGSSq6LmOqRnZfUvkiMWoYA+yckIrFbfdZNjkNDyNOQyVkEyIeaD+Jc1PrQbr4Rs84WSQvEjwfasCdLWWDvWMwHk3laIwFcv60b5fbrv02BlWqHQKEARuI1uJYSvyAXVKyP++mjjCd1rSX7RGL31OqxDsxLhH4aGpAMX2GQBfPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781624976; c=relaxed/simple; bh=21vYIL74mxpeNx4u6NItwmUerqH9jsPGBvmbegFGWyQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=B6wXHT7QbGt1oAMKPDMIOHvCMV65KmsKt1+oJSRGCczvp3CylXWaY0D2Dlw3BqP/LFe4IudLNUQ2UQDyEuAn4u04I5ek5TuJIE7bGDTj3a879Kn17rSqpT3IPVeTydjIkdikjUAP8otX40DihnelT6HGCR+SPkKhHsJuJ+N152Y= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=OgUzxIdt DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 651B048FBCA5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1781624975; bh=21vYIL74mxpeNx4u6NItwmUerqH9jsPGBvmbegFGWyQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OgUzxIdt6EHiTlJhHEDReNmJrzw0UUIx7BPoY/prAbbcWSwwb+z1C8WWQg2d9HyI7 ff0oNT3hqSPZMzfJs4ZKPd5kGo271tdw54aj0shmqWOYaN8ndp3Yq/Te08TvkyP0rP FhkhTc9plY9nHVZaRYjl9sYDGelsGoCM6cPbsUEQ= Received: by simark.ca (Postfix) id 4C09A1E070; Tue, 16 Jun 2026 11:49:35 -0400 (EDT) Message-ID: <31b3b725-47fa-481b-b7da-27861de34ba1@simark.ca> Date: Tue, 16 Jun 2026 11:49:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: Remove redundant clear_proceed_status() call To: Claudiu Zissulescu , gdb-patches@sourceware.org Cc: pedro@palves.net, lancesix@amd.com References: <20260616145522.4488-1-claudiu.zissulescu-ianculescu@amd.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260616145522.4488-1-claudiu.zissulescu-ianculescu@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/16/26 10:55 AM, Claudiu Zissulescu wrote: > Remove redundant clear_proceed_status() call. The > init_wait_for_inferior(), which runs on the very next line, already > calls clear_proceed_status (0, false). > > Signed-off-by: Claudiu Zissulescu > --- > gdb/windows-nat.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c > index d9e924f16c6..f1660a02175 100644 > --- a/gdb/windows-nat.c > +++ b/gdb/windows-nat.c > @@ -1944,7 +1944,6 @@ windows_nat_target::do_initial_windows_stuff (DWORD pid, bool attaching) > if (!inf->target_is_pushed (this)) > inf->push_target (this); > windows_clear_solib (); > - clear_proceed_status (0); > init_wait_for_inferior (); > > inferior_appeared (inf, pid); > -- > 2.54.0 > Seems fine to me. Approved-By: Simon Marchi Simon