ser-mingw.c will be failed to build on GCC4.4.

ser-mingw.c will be failed to build on GCC4.4.

[Masaki Muranaka]

Hello,

Some functions in ser-mingw.c is declared with return value, with no return statement.
For example, console_select_thread(), pipe_select_thread(), file_select_thread().

This is not issue on GCC4.3 or below, but GCC4.4 treats them as warning.

I don't see how to fix these functions. Could someone review them?

--
Masaki Muranaka
Monami Software

Re: ser-mingw.c will be failed to build on GCC4.4.

[Joel Brobecker]

> Some functions in ser-mingw.c is declared with return value, with no
> return statement.  For example, console_select_thread(),
> pipe_select_thread(), file_select_thread().

All these functions are used as the initial function when creating
threads.  According to the MS documentation, the return value is
used to determine whether the function was successful or not.
In our case, I think that the thing to do is to add a "return 0"
at the end.

-- 
Joel

Re: ser-mingw.c will be failed to build on GCC4.4.

[Masaki Muranaka]

Hello Joel,
Thanks for your comment.

I reviewed them after I sent mail.
Your idea is reasonable. It shut GCC4.4's warnings up.
The another solustion is to add noreturn attribute, I guess.
Anyway I'll send some patches later.

On 2008/12/24, at 12:33, Joel Brobecker wrote:

>> Some functions in ser-mingw.c is declared with return value, with no
>> return statement.  For example, console_select_thread(),
>> pipe_select_thread(), file_select_thread().
>
> All these functions are used as the initial function when creating
> threads.  According to the MS documentation, the return value is
> used to determine whether the function was successful or not.
> In our case, I think that the thing to do is to add a "return 0"
> at the end.
>
> -- 
> Joel
>

Masaki Muranaka
Monami Software